Skip to content

fix(DemonEncounter): 调整逢魔Boss挑战次数识别区域 - #1821

Open
yEs1do wants to merge 1 commit into
runhey:devfrom
yEs1do:fix(DemonEncounter_ChallengeCount)
Open

yEs1do wants to merge 1 commit into
runhey:devfrom
yEs1do:fix(DemonEncounter_ChallengeCount)

Conversation

@yEs1do

@yEs1do yEs1do commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Bug Fixes:

  • 修正逢魔Boss今日挑战次数的识别区域,提升已完成挑战状态的判断准确性。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • 修正逢魔Boss今日挑战次数的识别区域,提升已完成挑战状态的判断准确性。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嘿——我已经审阅了你的更改,看起来很棒!

Sourcery 评估

已批准。


Sourcery 对开源项目免费——如果你喜欢我们的评审,请考虑分享给他人 ✨
Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@github-actions

Copy link
Copy Markdown
Contributor

Findings

  • 未发现未通过项

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Checklist for #1821 · codex · gpt56 · 8.9 AIC · ⌖ 2.55 AIC · ⊞ 12.2K ·

@github-actions

Copy link
Copy Markdown
Contributor

Change Summary

  • 将逢魔顶部今日挑战次数 OCR 区域从 (680,68,75,36) 调整为 (705,68,45,36)
  • assets.pydemon/ocr.json 的前后 ROI 已保持同步。
  • 不改变 OCR 结果解析逻辑:仍只匹配 0/11/1,无法识别时默认继续执行。

Reconstructed Intent

点击此处展开 - 这次改动最可能是为了把识别范围收窄到顶部挑战次数本身,避开“今日挑战次数”等文字或其他邻近内容,从而提高已完成挑战(`0/1`)的提前结束判断准确性。 - 该规则位于任务进入灯笼和 Boss 流程之前,识别为 `0/1` 时会直接结束当天任务。

Observed Constraints

点击此处展开 - 实现依赖固定的 1280×720 坐标布局,以及挑战次数文本实际落在新区域 `x=705..750, y=68..104` 内。 - 新区域必须完整包含 `0/1` 或 `1/1`(尤其是斜杠),否则 `detect_and_ocr` 无法匹配时会按默认路径继续。 - 两个资源定义必须持续同步;本次变更已同步,但没有配套截图/识别样例可验证边界。

Intent Alignment

  • 基本一致:改动范围只涉及该 OCR 规则的识别区域,且代码行为与“缩小识别区域、改善挑战次数识别”这一推断 intent 对齐。
  • 但关键约束仍未验证:diff 本身无法证明新 ROI 在所有实际 UI 状态、语言/布局变体下都完整覆盖次数文本。

Release Risk

  • 风险等级:中
  • 若新 ROI 截断数字或斜杠,识别失败会静默走“继续挑战”路径,可能多执行后续导航/挑战流程;虽然 Boss 入口还有次数保护,但会增加误操作或等待风险。
  • 固定坐标规则对分辨率、缩放及 UI 布局变化敏感,影响范围集中在逢魔任务的每日已挑战判断。

Validation Gaps

点击此处展开 - 未看到针对 `0/1`、`1/1` 两种状态的实际截图或 OCR 回归样例,无法确认新区域覆盖完整文本。 - 未看到不同 UI 状态(刚进入现世逢魔、已完成挑战、文字动画/刷新中)的识别验证。 - 建议至少用真实截图确认新旧 ROI 的 OCR 输出分别稳定得到 `0/1` 与 `1/1`,并确认识别失败时不会造成不期望的重复挑战。

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Intent for #1821 · codex · gpt56 · 12.8 AIC · ⌖ 2.61 AIC · ⊞ 12.1K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant