Skip to content

implement PartialEq<Vec<U>> for [T; N] and &[T; N] - #149045

Open
Qelxiros wants to merge 1 commit into
rust-lang:mainfrom
Qelxiros:array-vec-partialeq
Open

implement PartialEq<Vec<U>> for [T; N] and &[T; N]#149045
Qelxiros wants to merge 1 commit into
rust-lang:mainfrom
Qelxiros:array-vec-partialeq

Conversation

@Qelxiros

@Qelxiros Qelxiros commented Nov 18, 2025 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Closes #149017

@Centril you're mentioned in the FIXME; do you have thoughts on this?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 18, 2025
@rustbot

rustbot commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@reddevilmidzy

reddevilmidzy commented Nov 18, 2025

Copy link
Copy Markdown
Member

How about adding the test mentioned in the issue?

fn main() {
    let x = vec![1];
    let y = [1];
    let _ = x == y;
    let _ = y == x;
}

@JonathanBrouwer

JonathanBrouwer commented Nov 18, 2025

Copy link
Copy Markdown
Member

r? libs

@Mark-Simulacrum Mark-Simulacrum added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025
@theemathas theemathas mentioned this pull request Dec 18, 2025
Closed
@Amanieu

Amanieu commented Jan 7, 2026

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 4274547 has been approved by Amanieu

It is now in the queue for this repository.

@rust-bors

rust-bors Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-libs-api.

@bors

bors commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@Amanieu

Amanieu commented Jan 7, 2026

Copy link
Copy Markdown
Member

@bors r-

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 7, 2026
@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@Amanieu

Amanieu commented Jan 7, 2026

Copy link
Copy Markdown
Member

Actually this needs an FCP.

@rfcbot merge

@rust-rfcbot

rust-rfcbot commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Error encounted:
Provided team `` is invalid

@Amanieu

Amanieu commented Jan 7, 2026

Copy link
Copy Markdown
Member

@rfcbot merge libs-api

@Qelxiros

Qelxiros commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready
(I think the labels are weird, but this certainly shouldn't be waiting on me)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2026
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2026
@rustbot rustbot mentioned this pull request Jan 29, 2026
Open
@workingjubilee workingjubilee mentioned this pull request Feb 22, 2026
Open
@lqd lqd mentioned this pull request Mar 1, 2026
Closed
3 tasks
@Qelxiros

Qelxiros commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Is there anything else I need to do for this PR?

@rust-bors

This comment has been minimized.

Sign in to view
@theemathas theemathas added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Apr 21, 2026
eval-exec
eval-exec reviewed May 15, 2026
View reviewed changes

@eval-exec eval-exec left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Qelxiros please resolve conflicts.

View changes since this review

@Qelxiros
Qelxiros force-pushed the array-vec-partialeq branch from 4274547 to d85fb87 Compare May 15, 2026 16:24
@rustbot

rustbot commented May 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Qelxiros
Qelxiros force-pushed the array-vec-partialeq branch from d85fb87 to 381b5eb Compare May 15, 2026 17:26
@Qelxiros

Qelxiros commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@workingjubilee workingjubilee mentioned this pull request May 25, 2026
Closed
@theemathas

theemathas commented May 26, 2026

Copy link
Copy Markdown
Contributor

This could maybe cause type inference failures, so, let's do a crater run.

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 26, 2026
@bors
Auto merge of #149045 - Qelxiros:array-vec-partialeq, r=<try>
1779a86 
implement PartialEq<Vec<U>> for [T; N] and &[T; N]
@rust-bors

rust-bors Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1779a86 (1779a8680dcd39c56ed600627cf6742ef07ed78c, parent: 31a9463c6e2794a59ce57a8f37abc6966afc2a58)

@theemathas

theemathas commented May 26, 2026

Copy link
Copy Markdown
Contributor

@craterbot check

@craterbot

craterbot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-149045 created and queued.
🤖 Automatically detected try build 1779a86
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2026
@craterbot

craterbot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-149045 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-149045 is completed!
📊 43 regressed and 2 fixed (950352 total)
📊 5412 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149045/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 5, 2026
@clarfonthey clarfonthey added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api [DEPRECATED; DO NOT USE] labels Aug 12, 2026
@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161566) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eval-exec eval-exec eval-exec left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@Amanieu Amanieu

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing impl PartialEq<Vec<T>> for [T; N]