Check redundant_explicit_links against generated URLs - #156009
Open
qaijuang wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-author
qaijuang
changed the title
redundant_explicit_links against generated URLsredundant_explicit_links against generated URLs
Contributor
Author
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
April 30, 2026 16:46
78cc7d7 to
52290d1
Compare
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
April 30, 2026 17:35
52290d1 to
4c47005
Compare
qaijuang
marked this pull request as ready for review
April 30, 2026 19:36
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
April 30, 2026 19:49
4c47005 to
8a48cea
Compare
Contributor
Author
|
I just noticed #156711, which seems related to broader rustdoc/compiler path-resolution work. Does that tracking issue change the desired direction for this PR? If the preferred approach is to wait for the broader item-signature resolution mechanism, I’m happy to adjust/park this, but I’d appreciate guidance so I know whether this PR is still worth pursuing. |
Member
|
I've yet to review your PR (sorry about that), so I can't tell for certain. However, I'm inclined to believe that the feature described in that tracking issue is not relevant. Double-checking that later. |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
will rebase rq |
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
July 10, 2026 08:42
8a48cea to
da95d5c
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
GuillaumeGomez
approved these changes
Aug 24, 2026
Member
|
Sorry, just uncovered this PR in my "to review list". ^^' Thanks for the improvement! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 24, 2026
…t-links-url, r=GuillaumeGomez Check `redundant_explicit_links` against generated URLs Fixes rust-lang#155458. `rustdoc::redundant_explicit_links` checked explicit link destinations by resolving both the label and the destination as intra-doc paths. That misses links written as local rustdoc page URLs, such as `struct.B.html`, because those URLs do not appear in `doc_link_resolutions`. This PR keeps the existing path-resolution check and falls back to comparing the explicit destination with the local href that rustdoc would generate for the resolved label.
Member
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #161683 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#161683), which was unapproved. |
Contributor
Author
|
I’ll do rebase in a few mins 🫠 |
qaijuang
force-pushed
the
rustdoc-redundant-explicit-links-url
branch
from
August 24, 2026 19:14
da95d5c to
1f5e36d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
GuillaumeGomez
approved these changes
Aug 24, 2026
Member
|
Let's go again! =D @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 24, 2026
…t-links-url, r=GuillaumeGomez Check `redundant_explicit_links` against generated URLs Fixes rust-lang#155458. `rustdoc::redundant_explicit_links` checked explicit link destinations by resolving both the label and the destination as intra-doc paths. That misses links written as local rustdoc page URLs, such as `struct.B.html`, because those URLs do not appear in `doc_link_resolutions`. This PR keeps the existing path-resolution check and falls back to comparing the explicit destination with the local href that rustdoc would generate for the resolved label.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 24, 2026
…t-links-url, r=GuillaumeGomez Check `redundant_explicit_links` against generated URLs Fixes rust-lang#155458. `rustdoc::redundant_explicit_links` checked explicit link destinations by resolving both the label and the destination as intra-doc paths. That misses links written as local rustdoc page URLs, such as `struct.B.html`, because those URLs do not appear in `doc_link_resolutions`. This PR keeps the existing path-resolution check and falls back to comparing the explicit destination with the local href that rustdoc would generate for the resolved label.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 24, 2026
Rollup of 9 pull requests Successful merges: - #161689 (bootstrap: don't LTO C dependencies on aarch64) - #161553 (rustdoc: fix issue preventing "read more" links from generating.) - #161670 (Pass LargeDataThreshold to LLVM module IR) - #146529 (rustdoc: Nuke `--passes=list` and defossilize the passes infrastructure) - #156009 (Check `redundant_explicit_links` against generated URLs) - #159583 (Add new `invalid_markdown_table` rustdoc lint) - #161098 (PassWrapper: handle LLVM 24 change in function types) - #161641 (Check for missing rustfmt in the stdarch intrinsic test step sooner) - #161661 (Don't treat slashes as path seps after drive letters in verbatim paths) Failed merges: - #156749 (remove `box_patterns`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155458.
rustdoc::redundant_explicit_linkschecked explicit link destinations by resolving both the label and the destination as intra-doc paths. That misses links written as local rustdoc page URLs, such asstruct.B.html, because those URLs do not appear indoc_link_resolutions.This PR keeps the existing path-resolution check and falls back to comparing the explicit destination with the local href that rustdoc would generate for the resolved label.