Implement a new flag -Zdisable-fast-paths in trait solving#156172
Conversation
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
S-waiting-on-review
| themselves (default: no)"), | ||
| direct_access_external_data: Option<bool> = (None, parse_opt_bool, [TRACKED], | ||
| "Direct or use GOT indirect to reference external data symbols"), | ||
| disable_fast_paths: bool = (false, parse_bool, [UNTRACKED], |
There was a problem hiding this comment.
i think this in theory impacts behavior, so it should be TRACKED 🤔
There was a problem hiding this comment.
Ah, right. I actually got some codes failing to compile with the flags due to the overflow since we don't do compute_goal_fast_path with it but goes into the nested goals
|
@bors r=lcnr |
rust-bors
Bot
added
S-waiting-on-bors
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
Rollup merge of #156172 - ShoyuVanilla:slowbro, r=lcnr Implement a new flag `-Zdisable-fast-paths` in trait solving Discussion: [#t-types/trait-system-refactor > ask for help @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/583953725) r? lcnr
|
@rust-timer build 6cebd3e |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (6cebd3e): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 495.494s -> 495.573s (0.02%) |
|
Caused the regression in |
|
why is the old solver impacted? 🤔 |
|
This flag also affects some old solver optimization routines. But anyway, it's surprising that this impacts the perf in non-negligible amounts 🤔 |
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - rust-lang/rust#156058 (Print HRTB binders before fn qualifiers) - rust-lang/rust#156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - rust-lang/rust#156184 (Revert "remove `MethodReceiverExpr` special-casing") - rust-lang/rust#155957 (Revert const hacks and use const closures in std) - rust-lang/rust#156127 (Update `askama` version to `0.16.0`) - rust-lang/rust#156183 (Remove duplicate debug assert)
6 participants
Discussion: #t-types/trait-system-refactor > ask for help @ 💬
r? lcnr