Rollup of 13 pull requests#156720
Merged
Merged
Conversation
revert the offset loading, instead load in a wrapping fashion
Earlier patches added `big_endian_inverse` and used `transmute` instead of using `vreinterpret` due to an LLVM bug that has since been resolved
Instead of duplicating the stability attribute, re-use the `neon-stable` anchor through
Some intrinsics optimise to different instructions on big endian which leads to `assert_instr` failing
Revert changing number of passes depending on number of parameters
Some small overall improvements to stdarch-gen-arm
This enables the `big_endian_inverse` transformation to apply to this intrinsic.
This enables the `big_endian_inverse` transformation to apply to these intrinsics.
This enables the `big_endian_inverse` transform to apply to these intrinsics.
This enables the `big_endian_inverse` transform to apply to this intrinsic.
This enables the `big_endian_inverse` transform to apply to this intrinsic.
Manually written tests for `vcopy_laneq`, `vget{,q}_{high,low,lane}`,
`vcombine` and `vaddw_high` don't account for the expected differences
in output for big endian intrinsics and given that they duplicate the
testing of `intrinsic-test`, can be removed.
Changes the definition of `vabdl_high_u{8,16,32}` to match that of
`vabdl_high_s{8,16,32}` so that the `big_endian_inverse` transformation
can apply.
Writing these intrinsics in terms of the `vqtbl_$ty` functions rather than the `vqtbl` helper function preserves the behaviour while making them work in big endian.
Writing these intrinsics in terms of the `vqtbx_$ty` functions rather than the `vqtbx` helper function preserves the behaviour while making them work in big endian.
Some more changes in stdarch-gen-arm
loongarch: Use `intrinsics::simd` for vbit{clr,rev,set}
Porting some intrinsics to stdarch-gen-arm
gen-arm: Change definitions of some intrinsics
Instead of doing an `as {i,u}16` cast, we can use the same LLVM
intrinsics as when converting to `{i,u}{32,64}`, which is what Clang does
and ensures the intrinsic result matches.
Replace `println!` with `assert!` in HashMap documentation examples ## Changes - **`.keys()`** - **`.values()`** - **`.values_mut()`** - **`.iter()`** - **`.iter_mut()`**
…they Widen the result of `widening_mul`. Tracking issue: rust-lang#152016 This PR implements <rust-lang#152016 (comment)>, which mandates that `widening_mul` return a single, scalar value rather than a low/high tuple. Consequently, this method is removed from `u128` and `i128` as they are the widest integral types. It has also been removed from `usize` and `isize` due to portability concerns. Existing `widening_mul` usage has been replaced by equivalent calls to `carrying_mul` (which is logically identical to the old behaviour.) Existing – generic – non-doc tests have been removed. # Public API ```rust impl u8 { pub const fn widening_mul(self, rhs: Self) -> u16; } impl u16 { pub const fn widening_mul(self, rhs: Self) -> u32; } impl u32 { pub const fn widening_mul(self, rhs: Self) -> u64; } impl u64 { pub const fn widening_mul(self, rhs: Self) -> u128; } impl i8 { pub const fn widening_mul(self, rhs: Self) -> i16; } impl i16 { pub const fn widening_mul(self, rhs: Self) -> i32; } impl i32 { pub const fn widening_mul(self, rhs: Self) -> i64; } impl i64 { pub const fn widening_mul(self, rhs: Self) -> i128; } ```
…imonSapin Update `sysinfo` version to `0.39.2` Bugfixes and performance improvements.
…ck-diag-items, r=mejrs Add diagnostic items for IoBufReader and StdinLock Added two new diagnostic items for IoBufReader and StdinLock.
reduce usage of `box_patterns` in tests Part of rust-lang#156110.
rustbot
added
A-run-make
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 18, 2026
Rollup of 13 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7517636 (parent) -> 9eb3be2 (this PR) Test differencesShow 5419 test diffsStage 1
Stage 2
Additionally, 5370 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 9eb3be26b46eccea1de7448ea9cc3c1d20bb1a35 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 7517636f51 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 18, 2026
Collaborator
|
Finished benchmarking commit (9eb3be2): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.7%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -6.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 513.557s -> 510.171s (-0.66%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
feature(cfg_target_has_atomic_equal_alignment)#155006 (stabilizefeature(cfg_target_has_atomic_equal_alignment))OsStr::split_at#156444 (ImplementOsStr::split_at)global_asm!in statement positions #156582 (Allowglobal_asm!in statement positions)UncheckedIterator#156661 (RemoveUncheckedIterator)Copyforffi::FromBytesUntilNulError#152367 (DerivesCopyforffi::FromBytesUntilNulError)println!withassert!in HashMap documentation examples #156630 (Replaceprintln!withassert!in HashMap documentation examples)widening_mul. #156644 (Widen the result ofwidening_mul.)sysinfoversion to0.39.2#156653 (Updatesysinfoversion to0.39.2)box_patternsin tests #156704 (reduce usage ofbox_patternsin tests)r? @ghost
Create a similar rollup