Rollup of 19 pull requests by jhpratt · Pull Request #161497 · rust-lang/rust

jhpratt · 2026-08-22T07:57:09Z

Successful merges:

Build rustc and codegen backends with -Zembed-metadata=no #151061 (Build rustc and codegen backends with -Zembed-metadata=no)
Error on projection of dyn noncompat type in old trait solver #154992 (Error on projection of dyn noncompat type in old trait solver)
Allow self in const generics #157949 (Allow self in const generics)
trait_selection: fix assumptions-on-binders diagnostics #158588 (trait_selection: fix assumptions-on-binders diagnostics)
core: implement float conversion methods #159954 (core: implement float conversion methods)
Add Default implementation for std::sync::Once #160136 (Add Default implementation for std::sync::Once)
resolver diagnostics: don't swallow labels and point out similar items as a note, not a label #160835 (resolver diagnostics: don't swallow labels and point out similar items as a note, not a label)
Improve the ABI between the panic runtime and libstd #161048 (Improve the ABI between the panic runtime and libstd)
Add safety comments in alloc::Wtf8 #161292 (Add safety comments in alloc::Wtf8)
Add some rustc_type_ir comments #161444 (Add some rustc_type_ir comments)
Remove leftover immediate creation #161465 (Remove leftover immediate creation)
Use symlink_dir to create junctions on Windows instead of trying to use symbolic links in copy_link_internal #152433 (Use symlink_dir to create junctions on Windows instead of trying to use symbolic links in copy_link_internal)
Add Arc/Rc::strong_count_from_raw #159098 (Add Arc/Rc::strong_count_from_raw)
Update documentation for -Zdump-dep-graph #159282 (Update documentation for -Zdump-dep-graph)
Remove fields from TypeKind: Bool, Char, Float and Int #161401 (Remove fields from TypeKind: Bool, Char, Float and Int)
Avoid arming the Windows TLS destructor guard in fibers #161451 (Avoid arming the Windows TLS destructor guard in fibers)
Add myself to mailmap #161463 (Add myself to mailmap)
Use bitset for locals_with_use_data #161476 (Use bitset for locals_with_use_data)
Warn about running ui-fulldeps tests in stage 1 #161483 (Warn about running ui-fulldeps tests in stage 1)

Failed merges:

add internal DSL for testing binders #161443 (add internal DSL for testing binders)

The supposed output path was incorrect. Using `-Zdump-dep-graph` does NOT emit to `/tmp/dep_graph.gv`, but to 2 files, one being `dep_graph.txt` and the other `dep_graph.dot` in the current directory

…s as a note, not a label

This requires moving PanicPayload to alloc.

Canonical type-op queries discard NextGen constraints, so function-body failures never reached NLL. Evaluate those ops locally under -Zassumptions-on-binders and preserve the origin span on the resulting outlives constraints.

Keep this branch focused on reporting solver region constraints. The type-op behavior and its borrowck coverage are handled separately.

While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling.

Add some documentation for `rustc_type_ir` and `SolverDelegate`.

`from_immediate` calls left over from refactor d3d3485 can create invalid LLVM IR

… use symbolic links in `copy_link_internal`

These fields served to query the bitwidth for both and whether an integer is signed or not. The bitwith is now provided by `TypeId::bits` while the signedness can be gotten trough the earlier introduces `TypeId::is_signed`.

Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal` Symbolic links require extra privileges on Windows, so this falls back to creating junctions in `symlink_file` when operating on a directory.

…om-raw, r=Mark-Simulacrum Add Arc/Rc::strong_count_from_raw Tracking issue: rust-lang#157021 Accepted ACP: rust-lang/libs-team#792 Adds `strong_count_from_raw` to `Arc` and `Rc`: read the strong count directly from a raw pointer, without reconstructing the smart pointer. The existing workaround is `ManuallyDrop::new(Arc::from_raw(ptr))` + `strong_count`, which takes ownership of a reference the caller doesn't own and could cause a double free if not using it properly, the detailed motivation of this in the ACP. This PR implements strong count only, libs-api deferred weak count until there's a concrete use case. The body reads the counter by walking back `data_offset` the way `from_raw_in` does, instead of materializing a temporary `Arc`/`Rc`, the call can't accidentally take ownership, and the `Relaxed` load matches `strong_count`. Lives next to `increment_strong_count`/`decrement_strong_count`. Safety doc: pointer to the value of a live allocation with valid metadata (feeds `data_offset`), such as pointer returned by `into_raw`, `into_raw_with_allocator`, `as_ptr`. `T` aligned like that value, strong count ≥ 1 for the duration of the call.

@jackh726

…h726 Update documentation for `-Zdump-dep-graph` The supposed output path was incorrect. Using `-Zdump-dep-graph` does NOT emit to `/tmp/dep_graph.gv`, but to 2 files, one being `dep_graph.txt` and the other `dep_graph.dot` in the current directory r? @jackh726 :: Because kinda related to Incremental Systems Rethought.

@oli-obk

… r=oli-obk Remove fields from TypeKind: Bool, Char, Float and Int Tracking issue rust-lang#146922 r? @oli-obk Part of [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the context.

@ChrisDenton

…ering-dtors-in-fibers, r=ChrisDenton Avoid arming the Windows TLS destructor guard in fibers After rust-lang#157645, we use FLS to trigger destructors for thread locals. In bytecodealliance/wasmtime#14184, it turned out that there's an edge case we didn't cover: if `thread_local/guard/windows.rs::enable` is called from a fiber and later, in a different fiber: (1) the fiber is converted back to a thread and (2) the thread deletes the original fiber, we incorrectly triggers the FLS destructors prematurely. The fix is simple - avoid arming the FLS slot (setting it to 1) if the calling thread is a fiber. The issue happened on mingw because it does have target thread local. Tested locally by forcing `registered = false` and checked that the new test fails without the fix. r? @ChrisDenton

Add myself to mailmap

…use-data, r=folkertdev Use bitset for locals_with_use_data There seems to be very little reason to use Vec of bools, the whole map allocates space for every element anyway. Not sure how is impactful this is, I noticed it randomly in the code, but this seems like cleaner way to do it (and more common in the compiler codebase)

…, r=jieyouxu Warn about running ui-fulldeps tests in stage 1 Mentioned [here](rust-lang#136939 (comment)). r? jieyouxu

jhpratt · 2026-08-22T07:57:25Z

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

rust-bors · 2026-08-22T07:57:27Z

📌 Commit 3ac3be1 has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 19 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-* try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-bors · 2026-08-22T07:57:33Z

⌛ Trying commit 3ac3be1 with merge 83315db…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/32560995778

JonathanBrouwer · 2026-08-22T08:02:14Z

This contains #151061 which I suspect failed the previous rollup

rust-bors · 2026-08-22T08:08:37Z

This pull request was unapproved due to being closed.

JonathanBrouwer · 2026-08-22T08:08:57Z

@bors try cancel

rust-bors · 2026-08-22T08:09:00Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/32560995778

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

blyxyas and others added 30 commits July 14, 2026 13:47

Update documentation for -Zdump-dep-graph

1b0230e

The supposed output path was incorrect. Using `-Zdump-dep-graph` does NOT emit to `/tmp/dep_graph.gv`, but to 2 files, one being `dep_graph.txt` and the other `dep_graph.dot` in the current directory

Add Default implementation for std::sync::Once

9ad9fe0

fix

a8d9636

Error on projection of dyn noncompat type in old trait solver

15e32c5

Reduce number of error messages

953e278

Remove more redundant errors

1c18ee4

resolver diagnostics: don't swallow labels and point out similar item…

9ac7293

…s as a note, not a label

imagine developing on windows

0360271

Use Rust ABI for __rust_panic_cleanup

cf0a043

Directly use Box in the PanicPayload trait and __rust_panic_cleanup

8087334

This requires moving PanicPayload to alloc.

Mark PanicPayload and __rust_start_panic as safe

ae5215c

Avoid allocation when using dummy panic_unwind impl

3ef33b7

Mark __rust_drop_panic and __rust_foreign_exception as safe

ffc65e5

Fix assumptions-on-binders outlives diagnostics

32999f2

Generalize solver region constraint spans

2abc0f6

Clarify region constraint span documentation

1c21b08

Keep solver region constraints on the borrowck InferCtxt

b3fb32a

Canonical type-op queries discard NextGen constraints, so function-body failures never reached NLL. Evaluate those ops locally under -Zassumptions-on-binders and preserve the origin span on the resulting outlives constraints.

Bless trailing blank line in alias_outlives stderr

36597f7

Split type-op constraint fix from diagnostics

7bffce8

Keep this branch focused on reporting solver region constraints. The type-op behavior and its borrowck coverage are handled separately.

fix unrecognized link

8b18fda

Build rustc and codegen backends with -Zembed-metadata=no

bbc9e66

While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling.

add some documentation about shared abstraction layer

fa87d61

Add some documentation for `rustc_type_ir` and `SolverDelegate`.

core: implement float conversion methods

3c55beb

Add myself to mailmap

5d347d7

Avoid arming the Windows TLS destructor guard in fibers

373266b

Remove leftover immediate creation

13bf326

`from_immediate` calls left over from refactor d3d3485 can create invalid LLVM IR

Use symlink_dir to create junctions on Windows instead of trying to…

bbd34d2

… use symbolic links in `copy_link_internal`

Add safety comments in alloc::Wtf8, and update the link in core::Wtf8

8fe7ae5

reflection: remove fields from TypeKind::Int and Float

3c43eb0

These fields served to query the bitwidth for both and whether an integer is signed or not. The bitwith is now provided by `TypeId::bits` while the signedness can be gotten trough the earlier introduces `TypeId::is_signed`.

reflection: remove field from TypeKind::Bool and Char

1d2a65f

jhpratt added 8 commits August 22, 2026 03:57

Rollup merge of rust-lang#161463 - AsakuraMizu:mailmap, r=jieyouxu

55512f7

Add myself to mailmap

Rollup merge of rust-lang#161483 - Kobzol:ui-fulldeps-stage-1-warning…

3ac3be1

…, r=jieyouxu Warn about running ui-fulldeps tests in stage 1 Mentioned [here](rust-lang#136939 (comment)). r? jieyouxu

rust-bors Bot added the rollup A PR which is a rollup label Aug 22, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2026

JonathanBrouwer closed this Aug 22, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 19 pull requests - #161497

Rollup of 19 pull requests#161497
jhpratt wants to merge 53 commits into
rust-lang:mainfrom
jhpratt:rollup-G7szmQL

jhpratt commented Aug 22, 2026

Uh oh!

jhpratt commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

jhpratt commented Aug 22, 2026

Uh oh!

jhpratt commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rust-bors Bot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rust-bors Bot commented Aug 22, 2026 •

edited

Loading