bootstrap: Rename Build to Session - #161600
Conversation
This renaming should at least make Session and Builder easier to distinguish.
|
This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp. This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies If appropriate, please update |
rustbot
added
A-testsuite
rustbot
added
the
T-bootstrap
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
I think there was originally an intention that Config would only contain information read from bootstrap.toml, and that Build/Session would then contain additional information discovered from the environment, such as tool paths and git information. However, that's not really the case today, as there is quite a lot of environmental “impurity” in config loading/processing. |
There used to be much more of it, and actually a large part of that has already been removed. But yeah, there is still some I/O happening during Config parsing, that could be removed in theory, but it would also complicate bootstrap's code a bit, so not sure if it's worth it anymore. Definitely download-ci-rustc should be moved out of there though. |
|
You can r=me. |
|
r? Kobzol @bors r=Kobzol |
rust-bors
Bot
added
the
S-waiting-on-bors
|
|
rust-bors
Bot
removed
the
S-waiting-on-review
bootstrap: Rename `Build` to `Session` - Follow-up to rust-lang#161277 --- Having separate types named `Build` and `Builder` is quite confusing, especially since *build* by itself isn't a very informative name in the context of a build system. This PR therefore performs the change suggested in rust-lang#161277 (comment), renaming `Build` to `Session`. While *session* is not exactly the most descriptive name either, it at least has the virtue of being clearly distinct from *builder*. That should be helpful when trying to clarify the different roles of the two types. There should be no change to bootstrap behaviour.
bootstrap: Rename `Build` to `Session` - Follow-up to rust-lang#161277 --- Having separate types named `Build` and `Builder` is quite confusing, especially since *build* by itself isn't a very informative name in the context of a build system. This PR therefore performs the change suggested in rust-lang#161277 (comment), renaming `Build` to `Session`. While *session* is not exactly the most descriptive name either, it at least has the virtue of being clearly distinct from *builder*. That should be helpful when trying to clarify the different roles of the two types. There should be no change to bootstrap behaviour.
bootstrap: Rename `Build` to `Session` - Follow-up to rust-lang#161277 --- Having separate types named `Build` and `Builder` is quite confusing, especially since *build* by itself isn't a very informative name in the context of a build system. This PR therefore performs the change suggested in rust-lang#161277 (comment), renaming `Build` to `Session`. While *session* is not exactly the most descriptive name either, it at least has the virtue of being clearly distinct from *builder*. That should be helpful when trying to clarify the different roles of the two types. There should be no change to bootstrap behaviour.
bootstrap: Rename `Build` to `Session` - Follow-up to rust-lang#161277 --- Having separate types named `Build` and `Builder` is quite confusing, especially since *build* by itself isn't a very informative name in the context of a build system. This PR therefore performs the change suggested in rust-lang#161277 (comment), renaming `Build` to `Session`. While *session* is not exactly the most descriptive name either, it at least has the virtue of being clearly distinct from *builder*. That should be helpful when trying to clarify the different roles of the two types. There should be no change to bootstrap behaviour.
…uwer Rollup of 7 pull requests Successful merges: - #161648 (`rust-analyzer` subtree update) - #160132 (make `pad_i32` of `PassMode::cast` an integer) - #160705 (Remove `From<!> for T` *reservation* impl) - #161600 (bootstrap: Rename `Build` to `Session`) - #161665 (delegation: add tests for delegations to inherent impls) - #161637 (Clarify token cursor behaviour) - #161653 (Add codegen test for Vec::clear lowering to an unconditional store)
4 participants
Having separate types named
BuildandBuilderis quite confusing, especially since build by itself isn't a very informative name in the context of a build system.This PR therefore performs the change suggested in #161277 (comment), renaming
BuildtoSession.While session is not exactly the most descriptive name either, it at least has the virtue of being clearly distinct from builder. That should be helpful when trying to clarify the different roles of the two types.
There should be no change to bootstrap behaviour.