Expand on MIR type checking. - #2982
Merged
fallible-algebra merged 1 commit intoAug 24, 2026
Merged
Conversation
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
BoxyUwU
reviewed
Aug 24, 2026
|
|
||
| Doing this additional type checking pass on it also allows us to check our working: If something fails in MIR tyck that passed in HIR type checking, something has gone wrong. | ||
|
|
||
| MIR type checking should succeed if HIR type checking succeeds. This is not trivial for a number of reasons, one of which being the vestigial instances of Region Uniquification. |
Member
There was a problem hiding this comment.
i dont think "vestigial" is correct here
fallible-algebra
force-pushed
the
types-overhaul/mir-tyck
branch
from
August 24, 2026 15:18
20cfff9 to
16b9fcf
Compare
BoxyUwU
reviewed
Aug 24, 2026
| ## User types | ||
|
|
||
| At the start of MIR type-check, we replace all regions in the body with new unconstrained regions. | ||
| At the start of MIR type_check, we replace all regions in the body with new unconstrained regions. |
Member
There was a problem hiding this comment.
Suggested change
| At the start of MIR type_check, we replace all regions in the body with new unconstrained regions. | |
| At the start of MIR typechecking, we replace all regions in the body with new unconstrained regions. |
fallible-algebra
force-pushed
the
types-overhaul/mir-tyck
branch
from
August 24, 2026 15:33
16b9fcf to
4f8e147
Compare
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drilled too hard into this one topic, came back up with a small change to the MIR type check article.
This should be followed up with a couple of things: