More chain code refactoring - #7118
Open
matthewhughes934 wants to merge 3 commits into
Open
Conversation
Some general code cleanup, things like: * Replace some `ref` patterns with `&` ones * Only pass down only required field to helper function * Add comments for span attribute
I found the naming in this type quite confusing: all it was tracking was "does this comment belong on the same line", so use a bool for this purpose.
rustbot
added
the
S-waiting-on-review
So that I can be confidence that my future refactors aren't changing some untested behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm continuing to try and make this code more understandable as I walk
through it. All the changes here should be pure refactoring, so not
behavioural changes.
refactor(chain): refactor chain parsing
Some general code cleanup, things like:
refpatterns with&onesrefactor(chain): drop
CommentPositionI found the naming in this type quite confusing: all it was tracking was
"does this comment belong on the same line", so use a bool for this
purpose.
Add some more chain comment tests
So that I can be confidence that my future refactors aren't changing
some untested behaviour.
I did not use an LLM to create a change in this PR.
I used an LLM to create a change in this PR, and I have explained below how it was used.