feat(config): warn user if auto-install is enabled, take 2#4859
Open
rami3l wants to merge 4 commits into
Open
Conversation
…_RECURSION_COUNT` This commit clears the value of `RUSTUP_AUTO_INSTALL` and the `RUST_RECURSION_COUNT` environment variables before running tests, to make sure that every test case relying on their effects is explicitly setting them.
rami3l
force-pushed
the
feat/warn-auto-install-2
branch
6 times, most recently
from
5d4438c to
b2e4ba4
Compare
rami3l
force-pushed
the
feat/warn-auto-install-2
branch
from
b2e4ba4 to
a9611a3
Compare
djc
approved these changes
May 18, 2026
|
|
||
| /// Represents the result of an operation that may ensure the installation of a certain toolchain. | ||
| #[derive(Clone, Debug)] | ||
| pub(crate) struct Ensured<T> { |
Contributor
There was a problem hiding this comment.
Ensured is a pretty generic name. Something more specific might be nicer?
| } else if ensure_active_toolchain { | ||
| let (toolchain, source) = cfg.ensure_active_toolchain(force_non_host, true).await?; | ||
| info!("the active toolchain `{toolchain}` has been installed"); | ||
| info!( |
Contributor
There was a problem hiding this comment.
Could these be replaced by a Deref impl on Ensured?
| RustupError::ToolchainNotSelected(process.name().unwrap_or_else(|| "Rust".into())).into() | ||
| } | ||
|
|
||
| fn auto_install_warning(process: &Process, toolchain: impl Display, status: &UpdateStatus) { |
Contributor
There was a problem hiding this comment.
Could/should this take an Ensured? Could it be a method on Ensured? I'd suggest moving the Process argument last, since it's more boring/long-lived/less relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative design for #4454.
Closes #4445.
Opening a draft early to collect CI errors, please don't review yet 🙏This PR has minimized its dependencies on #4840 so hopefully it'll be easier to backport this to 1.29 as well.
Since #4840 is a breaking change, I'd still like to add some 1.29-exclusive deprecation warnings based on it (part of #4211).