fix(task-store): drop read lock before sleep; configurable broadcast cap#155
Open
SVilgelm wants to merge 3 commits into
Open
fix(task-store): drop read lock before sleep; configurable broadcast cap#155SVilgelm wants to merge 3 commits into
SVilgelm wants to merge 3 commits into
Conversation
The polling loop held the inner read guard across the sleep, blocking every create_task/store_task_result for the whole sleep. Scope the guard so it is released first, and make the status-change broadcast capacity configurable via with_capacity. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
The task polling loop held the inner
RwLockread guard acrosstokio::time::sleep, so everycreate_task/store_task_result(which need the write lock) was blocked for the entire sleep — potentially several seconds. The guard is now released before sleeping. The status-change broadcast capacity (previously a hard-coded 64) is also configurable.🔍 Related Issues
✨ Changes Made
sleep.awaitin the polling loop.InMemoryTaskStore::with_capacityto configure the broadcast channel capacity (newkeeps the default).