perf(transport): make the message channel capacity configurable#160
Open
SVilgelm wants to merge 4 commits into
Open
perf(transport): make the message channel capacity configurable#160SVilgelm wants to merge 4 commits into
SVilgelm wants to merge 4 commits into
Conversation
The incoming-message channel used a hard-coded capacity of 36, causing head-of-line jitter under bursts. Expose it via TransportOptions::channel_capacity (default unchanged) and thread it through MCPStream::create. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
The incoming-message channel used a hard-coded capacity of 36, which is fine for request/response stdio but causes head-of-line jitter under bursty traffic. The capacity is now configurable via
TransportOptions::channel_capacity(default unchanged), threaded throughMCPStream::create/create_with_ack. Slow SSE clients continue to be handled by the existing ping interval.🔍 Related Issues
✨ Changes Made
TransportOptions::channel_capacity(defaultDEFAULT_MESSAGE_CHANNEL_CAPACITY= 36).channel_capacityparameter toMCPStream::create/create_with_ack; stdio/SSE server transports source it from their options.