Provide wcslen for x86_64-unknown-uefi target - #582
Closed
andrewdavidmackenzie wants to merge 1 commit into
Closed
andrewdavidmackenzie wants to merge 1 commit into
andrewdavidmackenzie wants to merge 1 commit into
Conversation
The uefi crate's FileInfo::from_uefi and RegularFile::get_info reference wcslen for wide string length calculation. The x86_64-unknown-uefi target has no C runtime providing this symbol, causing a linker error. Add a simple wcslen implementation to the UEFI bootloader binary. Use #[unsafe(no_mangle)] for compatibility with Rust 2024 edition. Fixes: rust-osdev#579
This was referenced Sep 16, 2026
Member
|
Thanks for submitting! This should no longer be needed on the latest Rust nightly. It was fixed in compiler_builtins directly in rust-lang/compiler-builtins#1297, which rust-lang/rust upgraded to in rust-lang/rust#162816. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ueficrate'sFileInfo::from_uefiandRegularFile::get_inforeferencewcslenfor wide string length calculation. Thex86_64-unknown-uefitarget has no C runtime providing this symbol, causing a linker error:This adds a simple
wcslenimplementation to the UEFI bootloader binary.Fixes #579