Adapted for OHOS#567
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds ChangesOHOS Platform Support
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Build as Cargo target configuration
participant Runtime as OHOS runtime
participant TLS as Proxy/Websocket TLS
participant Cache as TLS cache
Build->>Runtime: Select OHOS cfg and rustls dependencies
Runtime->>TLS: Create rustls connector for TLS connections
TLS->>Cache: Skip NativeTls cache update on OHOS
TLS-->>Runtime: Return connection or fail without native-TLS fallback
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
OHOS is “OpenHarmonyOS” |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Line 36: Pin the forked sodiumoxide dependency in Cargo.toml by replacing the
floating branch reference with a fixed rev or tag, and if this fork is only
needed for OHOS, move the dependency entry into the OHOS target-specific section
instead of keeping it global. Locate the existing sodiumoxide dependency
declaration and update it so builds use a stable, reproducible source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Since the upstream sodiumoxide is archived, I had to fork it to make the necessary adaptations for openharmonyos via a git link. |
Summary by CodeRabbit