feat: adding pkgs support for cross-compilation#161
Conversation
| , clang-unwrapped ? defaultClangUnwrapped | ||
| , stdenv ? defaultStdenv | ||
| , isLintShell ? false | ||
| , craneArgs ? { } |
There was a problem hiding this comment.
Is this really needed? I thought we'd just modify mergeArgs to scan through buildInputs and buildNativeInputs and apply pkgs over functions there.
There was a problem hiding this comment.
I did try the mergeArgs route but it was a pain passing the buildInputs and nativeBuildInputs across different targets.
Resolving the packages as early as possible to pass it directly to mkFenixToolchain ended up working smoothly
|
We'll need tests in ./checks that make sure it works. But right now that |
|
Got it, thanks for the review. I did not manage to get |
|
Hey @dpc, coming back to this PR
Tell me if there are still blockers to merge this |
|
I never really had stamina to fully figure it out while it was (AFAICT) slightly off, and personally I did not care about it, so I never did it. I decided to have a clanker help me with it now: #239 |
closes #160.
This should not introduce any breaking changes, we can now pass a
buildInputsandnativeBuildInputslambda tocraneMultiBuildthat we get resolved inmkStdToolchainsand ultimately passed tocraneLibinmkFenixToolchain.EDIT: I just realized my new commits were also forwarded to this PR, they basically add new targets (linux musl variants + windows64 with mingw).