Skip to content
This repository was archived by the owner on Oct 15, 2022. It is now read-only.

Fix non-default locale recognition on Android#25

Open
olexale wants to merge 1 commit into
rxlabz:masterfrom
olexale:master
Open

Fix non-default locale recognition on Android#25
olexale wants to merge 1 commit into
rxlabz:masterfrom
olexale:master

Conversation

@olexale

@olexale olexale commented Feb 17, 2019

Copy link
Copy Markdown

According to documenation EXTRA_LANGUAGE value should be

IETF language tag (as defined by BCP 47), for example "en-US"

So I just replaced Locale with the correct format and that fixed #2 for me. I tested those changes with Android 6 and 8.

Eimji added a commit to Eimji/speech_recognition that referenced this pull request Mar 25, 2019
@brunohaetinger

Copy link
Copy Markdown

When it will be merged?

@Eimji

Eimji commented Mar 27, 2019

Copy link
Copy Markdown

I can confirm, it works now on Android with the fix by olexale !!!!
Big thanks :)

@Gnurou

Gnurou commented May 30, 2019

Copy link
Copy Markdown

Confirmed as well, without this fix non-US locales aren't recognized on Android (even the example app does not work as expected). With it they work like a charm.

@ngocdaothanh

Copy link
Copy Markdown

Hi, can you please merge this PR and release a new version?

@issam1975

issam1975 commented Jul 4, 2019

Copy link
Copy Markdown

yes i can confirm too that this fix did the trick .

tested with arabic, gj

@tsinis

tsinis commented Sep 12, 2019

Copy link
Copy Markdown

Hi, any chance to merge it?

@olexale

olexale commented Sep 12, 2019

Copy link
Copy Markdown
Author

Hi @tsinis ,
You may fork the repository, merge those changes in your fork, and use your custom plugin version, or use already patched version by changing your pubspec.yaml file like that:

speech_recognition:
    git:
      url: git://github.com/olexale/speech_recognition.git

@tsinis

tsinis commented Sep 19, 2019

Copy link
Copy Markdown

Hi @tsinis ,
You may fork the repository, merge those changes in your fork, and use your custom plugin version, or use already patched version by changing your pubspec.yaml file like that:
speech_recognition:
git:
url: git://github.com/olexale/speech_recognition.git

Hi @olexale
Yeah its working, but onRecognitionComplete is never return, and _isListening is always true, in example app... on real Android device (android pie).

P.S.
спасибо

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android, not able to use other Locales

7 participants