boFix X11 Unicode typing, Pillow bound, and security contact - #3
Open
wachawo wants to merge 1 commit into
Open
Conversation
The X11 input backend fell back to ord(character) as a keysym for anything XK.string_to_keysym did not know, which is only valid for Latin-1. Cyrillic, CJK, and most symbols therefore mapped into unrelated keysym ranges and were dropped or typed as the wrong key. Use the 0x01000000 Unicode keysym namespace instead and, when the active layout has no keycode for the keysym, bind an unused keycode for the session and unbind it on close, the same approach xdotool takes. Raise the Pillow requirement to 9.1, the first release that ships the Image.Resampling, Image.Quantize, and Image.Dither enums used by the capture and render modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X11 input backend fell back to ord(character) as a keysym for anything XK.string_to_keysym did not know, which is only valid for Latin-1. Cyrillic, CJK, and most symbols therefore mapped into unrelated keysym ranges and were dropped or typed as the wrong key. Use the 0x01000000 Unicode keysym namespace instead and, when the active layout has no keycode for the keysym, bind an unused keycode for the session and unbind it on close, the same approach xdotool takes.
Raise the Pillow requirement to 9.1, the first release that ships the Image.Resampling, Image.Quantize, and Image.Dither enums used by the capture and render modules.