chore(repo): reconcile BattleGrid main drift#51
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7e3d234ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allowBuilds: | ||
| esbuild: true |
There was a problem hiding this comment.
Make approval visible to prefixed installs
When dependency installation is run through the repo’s existing paths that use pnpm --prefix client install (for example the client CI jobs and Makefile build-client target), pnpm does not load this client/pnpm-workspace.yaml; I checked pnpm --prefix client config get only-built-dependencies from the repo root and it returns undefined, while running from client sees esbuild. This means pnpm v10 installs still run without the esbuild build approval in the scripted verification path this change is trying to fix; move the approval to a config location those prefixed installs read or change the install commands to run with client as the pnpm directory.
Useful? React with 👍 / 👎.
307dafa to
8526578
Compare
|
Closed after landing the clean verification-environment fix directly on main at e7d4289. This PR branch now carries stale reconcile history and is no longer the source of truth. |
What
Why
BattleGrid was showing as dirty and heavily diverged in the portfolio restart packet even though most local history had already landed remotely. The remaining drag was case-duplicate template state plus local verification environment friction.
How
Testing
bash .codex/scripts/run_verify_commands.shPerformance impact
Risk / Notes
Screenshots (UI only)
Lockfile rationale (if lockfile changed)
Baseline governance (if .perf-baselines changed)