Skip to content
This repository was archived by the owner on Jun 7, 2026. It is now read-only.

chore(repo): reconcile BattleGrid main drift#51

Closed
saagpatel wants to merge 1 commit into
mainfrom
codex/chore/reconcile-main-drift
Closed

chore(repo): reconcile BattleGrid main drift#51
saagpatel wants to merge 1 commit into
mainfrom
codex/chore/reconcile-main-drift

Conversation

@saagpatel

Copy link
Copy Markdown
Owner

What

  • Removes the duplicate lowercase PR template so macOS checkouts keep one canonical template path.
  • Keeps the branch current with origin/main after the prior local drift.
  • Adds explicit pnpm esbuild build approval and makes the WASM build wrapper prefer the rustup toolchain when available.

Why

BattleGrid was showing as dirty and heavily diverged in the portfolio restart packet even though most local history had already landed remotely. The remaining drag was case-duplicate template state plus local verification environment friction.

How

  • Merged current origin/main into a Codex branch.
  • Kept current remote dependency/workflow pins during conflict resolution.
  • Normalized the PR template to the uppercase GitHub path.
  • Hardened local verification around pnpm build approval and wasm32 target visibility.

Testing

  • Commands run: bash .codex/scripts/run_verify_commands.sh
  • Results: passed

Performance impact

  • Bundle delta: no product bundle change intended
  • Build time delta: no product build-path change intended beyond making WASM verification use the existing rustup target
  • Lighthouse delta: not applicable
  • API latency delta: not applicable
  • DB query delta: not applicable

Risk / Notes

  • GitHub reported one existing low Dependabot alert on default branch during push.
  • Local Playwright required installing the matching Chromium payload before the final successful verification.

Screenshots (UI only)

  • Not applicable

Lockfile rationale (if lockfile changed)

  • Lockfile was not changed by this PR.

Baseline governance (if .perf-baselines changed)

  • Not applicable

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7e3d234ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1 to +2
allowBuilds:
esbuild: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make approval visible to prefixed installs

When dependency installation is run through the repo’s existing paths that use pnpm --prefix client install (for example the client CI jobs and Makefile build-client target), pnpm does not load this client/pnpm-workspace.yaml; I checked pnpm --prefix client config get only-built-dependencies from the repo root and it returns undefined, while running from client sees esbuild. This means pnpm v10 installs still run without the esbuild build approval in the scripted verification path this change is trying to fix; move the approval to a config location those prefixed installs read or change the install commands to run with client as the pnpm directory.

Useful? React with 👍 / 👎.

@saagpatel saagpatel force-pushed the codex/chore/reconcile-main-drift branch from 307dafa to 8526578 Compare June 7, 2026 14:36
@saagpatel

Copy link
Copy Markdown
Owner Author

Closed after landing the clean verification-environment fix directly on main at e7d4289. This PR branch now carries stale reconcile history and is no longer the source of truth.

@saagpatel saagpatel closed this Jun 7, 2026
@saagpatel saagpatel deleted the codex/chore/reconcile-main-drift branch June 7, 2026 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant