You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is quite a bit of code to handle what will most likely be an
extremely rare edge case, but I'd rather deal with this before it
becomes a problem in production and causes a real headache
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Shared-stream backpressure, stale logger configuration, and release compatibility remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review details
Files not reviewed (1)
packages/logger/package-lock.json: Generated file
Suppressed comments (2)
packages/logger/README.md:49
The public Sink API has no type discriminator or separate console variant; every sink is configured with a Node.js Writable stream. This sentence advertises sink types that do not exist. Describe stdout and stderr as writable-stream examples instead.
The supported sink types are `console` and `stream`.
packages/logger/CHANGELOG.md:19
This release note still says callers can configure a console sink, but the replacement API exposes only writable-stream sinks. Update the migration guidance so it matches the new Sink type.
- Removed `SSQT_LOG_TRANSPORTS`; configure `console` or writable `stream` sink through `initializeLogger`.
LoggerConfig no longer accepts logLevel, but packages/express-boilerplate/src/tests/util.ts:12-14 still initializes the test logger with { logLevel: "crit" }. That excess property fails TypeScript compilation now that Express resolves this API; if type checking is bypassed, it is silently ignored and the logger uses the default info level and stdout sink. Update the helper to use level: "crit" and explicitly set sinks if tests should remain quiet.
Correct migration note for writable-stream sink configuration
packages/logger/CHANGELOG.md:19
The replacement API has no console or stream sink discriminator; each sink is { stream: Writable }. Update this migration note so it describes the actual initializeLogger configuration.
Document sinks as writable streams only
packages/logger/README.md:49
The public Sink API only accepts { stream: Writable }; it has no console or stream type discriminator. This sentence advertises configuration variants that consumers cannot use. Describe writable-stream sinks instead.
This reference-style [4.0.0] heading has no matching link definition at the bottom of the changelog, unlike the existing release headings, so it renders as plain bracketed text. Add the 4.0.0 release reference when the release URL is finalized.
The new Sink API accepts only { stream: Writable }; there is no console sink kind. This migration note should describe the supported writable-stream configuration rather than direct users to a removed transport type.
Correct Sink documentation to describe writable streams
packages/logger/README.md:49
The exported Sink type is { stream: Writable }; it has no console or stream discriminator. This sentence could lead users to try the removed transport-style configuration, so describe stdout and stderr as writable streams instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Winston with a much more lightweight in-house logger implementation.
Rationale: