Repository navigation
Review recent Rubyboy changes - #35
Merged
Merged
Conversation
Drop audio that cannot be played in time instead of waiting when --unlimited is used, so audio no longer slows emulation down. Remove --no-audio, rubyboy-bench --render and --json, and the VSync support that required SDL 2.0.18. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete opcodes.json, the raylib backend, the broken stackprof helper with Emulator#bench and its gems, and the finished -O4 comparison script. Stop passing frame counts, runtime details and the unused stop message through the browser worker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ruby.wasm and Spinel builds packed every file under lib/, including local battery saves and save states. Copy only tracked files before packing, and check the packed file list against git ls-files in the verification scripts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the custom Ruby 4.0.7 source pin in favor of ruby_wasm's 4.0 alias. Fold the packed-file check into the ruby.wasm runtime smoke test, remove its CRuby comparison, and keep only the pacing, input and audio buffer tests for the shared browser code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shorten README and fix its key table. Add BENCHMARK.md for running rubyboy-bench on CRuby and Spinel, and spinel/README.md for native Spinel builds. Move the browser build, test and deploy instructions for both WebAssembly versions into wasm/README.md, and remove docs/wasm-playback.md from the GitHub Pages directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compile the browser entry points with Spinel's --ext-init and --ext-entry, export them through a small C glue file, and link with the flags from spinel --print-build. Embed the tracked ROM files as a custom section and load them with a small JavaScript loader, replacing the --ext wasm host that required unpublished Spinel changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the browser tests and the CRuby reference into wasm/test. Drop the unused return value of Executor#exec, the unused vm field and the duplicate ROM name check in RubyboyVM, which Executor already performs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move rubyboy-wasm from exe/ to wasm/ and drop it from the gem's executables, since it only works inside the repository. Exclude docs/, spinel/ and wasm/ from the packaged files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review the changes from bac2541 to be7d23b, including subsequent fixes. This PR uses a historical base so the complete diff remains visible.