Repository navigation
Fix overflow in Multi::timeout_i32 - #663
Merged
Merged
Conversation
rizwan3659
force-pushed
the
fix-timeout-i32-overflow
branch
from
September 10, 2026 14:14
30e397e to
ec987c0
Compare
sagebind
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timeout_i32has an off-by-one in its clamp check. It compares the wholeseconds against
i32::MAX / 1000using>, so a duration of exactly2147483 seconds skips the clamp and goes into the arithmetic branch. If the
sub-second part is 648ms or more,
secs * 1000 + millisends up pasti32::MAX.In debug builds this panics with "attempt to add with overflow". In release
builds it wraps around to a negative number instead, and libcurl's
multi_wait()rejects negative timeouts, soMulti::wait()andMulti::poll()returnCURLM_BAD_FUNCTION_ARGUMENTinstead of waiting.This changes it to work out the timeout in milliseconds first and then clamp
it to
i32::MAX, so there's no intermediate value that can overflow. I alsoadded a unit test for the boundary values and for
Duration::MAX.Fixes #659