Repository navigation
Conversation
oauth2_bearer(token) plus Auth::bearer let libcurl send "Authorization: Bearer" itself instead of callers composing the header; netrc_file(path) points netrc at a file other than ~/.netrc, which is what tests and tools with their own config directory need. Both were already in libcurl; the sys constants existed (one commented out). Tests check the header on the wire.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small setopts libcurl has had for years:
Easy::oauth2_bearer(token)(CURLOPT_XOAUTH2_BEARER) together with the newAuth::bearer(true)(CURLAUTH_BEARER) makes libcurl sendAuthorization: Bearer <token>itself. Until now callers had to compose the header by hand, which also meant libcurl did not know it was authenticating.Easy::netrc_file(path)(CURLOPT_NETRC_FILE) reads credentials from a file other than~/.netrc, for tools with their own config directory and for tests that cannot changeHOME.Both on
EasyandEasy2. The sys constant for the netrc file already existed; the bearer one was there as a comment. Two tests intests/easy.rscheck theAuthorizationheader on the wire.