W-22415490 feat: add generation of top level graphqlrc.yml file for generating react uiBundles#936
Open
emanchan wants to merge 1 commit into
Conversation
emanchan
changed the title
emanchan
changed the title
jodarove
reviewed
May 13, 2026
| templates: getCustomTemplates(this.configAggregator), | ||
| }); | ||
|
|
||
| if (flags.template === 'reactbasic') { |
There was a problem hiding this comment.
in theory, this should be part of all UIBundles, in fact, maybe all of the sfdx projects. the issue is that in lwc ones, we don't pull the schema down.
Note: i would feel more comfortable if we add it for the ones we know and pull the schema.
| templateType: TemplateType.UIBundle, | ||
| opts: flagsAsOptions, | ||
| ux: new Ux({ jsonEnabled: this.jsonEnabled() }), | ||
| templates: getCustomTemplates(this.configAggregator), |
There was a problem hiding this comment.
Where's the origin of these "CustomTemplates"? what's the difference between adding it here (flags.template below), versus in the reactbasic "customTemplate"?
| return { | ||
| ...result, | ||
| created: [...result.created, targetRelative], | ||
| rawOutput: `${result.rawOutput.replace(/\n$/, '')}\n create ${targetRelative}\n`, |
There was a problem hiding this comment.
is it create or created? we should match the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-22415490@