Conversation
…me transmission from WebSocket outgoing messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Connection Mode" setting to the app, allowing users to select between Network, Dynamic, and Nearby modes for device connectivity. The changes unify and modernize the connection logic, update the UI to reflect the new setting, and improve BLE and discovery management for better reliability and clarity.
Connection Mode Setting and Logic:
AppConnectionModeenum toAppState, supporting.network,.dynamic, and.nearbymodes, with localized display names. The selected mode is persisted inUserDefaults, and legacy BLE settings are migrated for backward compatibility. Changing the mode updates BLE enablement and discovery behavior accordingly. [1] [2] [3]UI Updates:
Discovery and BLE Improvements:
DiscoveryManagernow respects the selected connection mode, skipping discovery if set to Nearby-only. BLECentralManager improvements include preventing duplicate service requests, ensuring proper cleanup on disconnect, and fixing notification subscription logic. [1] [2] [3] [4] [5] [6] [7] [8]Localization:
Code Cleanup:
WebSocketServer+Outgoing.swift.