Skip to content

Develop - Connection mode picker and major connection improvements - #291

Merged
sameerasw merged 2 commits into
mainfrom
develop
Aug 21, 2026
Merged

Develop - Connection mode picker and major connection improvements#291
sameerasw merged 2 commits into
mainfrom
develop

Conversation

@sameerasw

Copy link
Copy Markdown
Owner

This pull request introduces a new "Connection Mode" setting to the app, allowing users to select between Network, Dynamic, and Nearby modes for device connectivity. The changes unify and modernize the connection logic, update the UI to reflect the new setting, and improve BLE and discovery management for better reliability and clarity.

Connection Mode Setting and Logic:

  • Added AppConnectionMode enum to AppState, supporting .network, .dynamic, and .nearby modes, with localized display names. The selected mode is persisted in UserDefaults, and legacy BLE settings are migrated for backward compatibility. Changing the mode updates BLE enablement and discovery behavior accordingly. [1] [2] [3]

UI Updates:

  • Updated the Settings and Connection Status UI to use a segmented picker for selecting the connection mode, with localized labels and descriptions for each option. The previous BLE toggle is replaced by the new picker, and descriptive text is shown for the selected mode. [1] [2] [3] [4] [5]

Discovery and BLE Improvements:

  • The DiscoveryManager now respects the selected connection mode, skipping discovery if set to Nearby-only. BLECentralManager improvements include preventing duplicate service requests, ensuring proper cleanup on disconnect, and fixing notification subscription logic. [1] [2] [3] [4] [5] [6] [7] [8]

Localization:

  • Added new localization strings for the connection mode setting and its descriptions.

Code Cleanup:

  • Removed redundant code related to sending the device name over BLE in WebSocketServer+Outgoing.swift.

@sameerasw sameerasw self-assigned this Aug 21, 2026
@sameerasw sameerasw added the enhancement New feature or request label Aug 21, 2026
@sameerasw
sameerasw merged commit 93fe85f into main Aug 21, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in AirSync Features and Bugs Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant