Repository navigation
deploy: use Core startup migration on Kubernetes - #4
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes template invokes
oac-core-migrate, but current upstream images contain no such binary and Core now applies the schema before opening its database pool and listening. This causes new deployments to fail in the migration init container.Remove that init container and rely on Core's maintained startup migration path. Preserve secret/state preparation, process configuration, mounts, security settings and the single-replica Recreate strategy. Update deployment documentation to match.
Validation: rendered manifest parsing and assertions for preparation/env/secrets/Recreate, git diff --check, source/image contract inspection and independent review. The failed rollout was cancelled and the previous Core restored Ready; production release will use the corrected beta revision after checks.