Skip to content

SOFAST Slice Plot Utility - #334

Open
alhs6577 wants to merge 6 commits into
sandialabs:developfrom
alhs6577:my_test_branch
Open

SOFAST Slice Plot Utility#334
alhs6577 wants to merge 6 commits into
sandialabs:developfrom
alhs6577:my_test_branch

Conversation

@alhs6577

Copy link
Copy Markdown

Purpose

Adding slice plot utility to SOFAST post-processing.

Summary of changes

-Majority under StandardPlotOutput.py:
-Addition of curvature deviation as figure output
-Ability to save figure data (slope, slope deviation, curvature, curvature deviation, enclosed energy) as hdf5 output
-Addition of slice plot utility to generate multiple 2D slices in X or Y directions across slope/slope deviation/curvature/curvature deviation
-Addition of plot showing locations of slices
-Addition of plot showing comparison of measured and reference data for slope
-Addition of slice data saved as both hdf5 and csv output
-Addition of plot functionality for slice plot output including profile offsets and x-axis limits
-Addition of generic uncertainty bars to slice plot output figures (subject of future work)
-Update of ini file in sofast_fringe/single_facet example to support new changes
-Adjustments to VisualizeOrthorectifiedSlopeAbstract.py to allow data output

Implementation notes

-Additions tested using sofast_fringe/single_facet example.

Submission checklist

  • Target branch is develop, not main
  • Existing tests are updated or new tests were added
  • opencsp/test/test_DocStringsExist.py are verified to include this change or have been updated accordingly
  • .rst file(s) under doc/ are verified to include this change or have been updated accordingly

@jehsharp
jehsharp self-requested a review July 27, 2026 21:40

@jehsharp jehsharp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!

Try running this command in your OpenCSP directory and it should fix at least the black format test failing:

$ black -C -S .

I am also seeing some file not found errors for the ubi8-ci and windows2022-ci tests. Let me take a closer look at those.

@jehsharp jehsharp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alan, The ubi8 and Windows test are failing because there seems to be a missing docstring on line 614 of StandardPlotOutput.py (opencsp/common/lib/csp/StandardPlotOutput.py). If you add a simple docstring on that line, like:

"""Plots combined measured reference slopes"""

That should fix that failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants