SOFAST Slice Plot Utility - #334
Open
alhs6577 wants to merge 6 commits into
Open
Conversation
jehsharp
self-requested a review
July 27, 2026 21:40
jehsharp
requested changes
Jul 27, 2026
jehsharp
left a comment
Collaborator
There was a problem hiding this comment.
The code looks good!
Try running this command in your OpenCSP directory and it should fix at least the black format test failing:
$ black -C -S .
I am also seeing some file not found errors for the ubi8-ci and windows2022-ci tests. Let me take a closer look at those.
jehsharp
reviewed
Aug 3, 2026
jehsharp
left a comment
Collaborator
There was a problem hiding this comment.
Hey Alan, The ubi8 and Windows test are failing because there seems to be a missing docstring on line 614 of StandardPlotOutput.py (opencsp/common/lib/csp/StandardPlotOutput.py). If you add a simple docstring on that line, like:
"""Plots combined measured reference slopes"""
That should fix that failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adding slice plot utility to SOFAST post-processing.
Summary of changes
-Majority under StandardPlotOutput.py:
-Addition of curvature deviation as figure output
-Ability to save figure data (slope, slope deviation, curvature, curvature deviation, enclosed energy) as hdf5 output
-Addition of slice plot utility to generate multiple 2D slices in X or Y directions across slope/slope deviation/curvature/curvature deviation
-Addition of plot showing locations of slices
-Addition of plot showing comparison of measured and reference data for slope
-Addition of slice data saved as both hdf5 and csv output
-Addition of plot functionality for slice plot output including profile offsets and x-axis limits
-Addition of generic uncertainty bars to slice plot output figures (subject of future work)
-Update of ini file in sofast_fringe/single_facet example to support new changes
-Adjustments to VisualizeOrthorectifiedSlopeAbstract.py to allow data output
Implementation notes
-Additions tested using sofast_fringe/single_facet example.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordingly