Y26 173 create sapio study#5897
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Epic/Sapio_study_integration #5897 +/- ##
================================================================
- Coverage 84.82% 84.81% -0.02%
================================================================
Files 1491 1492 +1
Lines 33976 34004 +28
Branches 3627 3632 +5
================================================================
+ Hits 28821 28841 +20
- Misses 4303 4310 +7
- Partials 852 853 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yoldas
left a comment
There was a problem hiding this comment.
issue: In order to create a Study using this API endpoint, there needs to be some agreement with the Integration Hub team. Ideally all metadata or any other associated information should be packed into the payload as *_attributes such as study_metadata_atrributes, so the associations can be established in one go by treating those extra nested structures. The study_params used here is not documented. It is not clear what it is doing. See the relationships
- study
- study_metadata
- study_type
- data_release_study_type
- reference_genome
- program
- user
- study_metadata
issue: no API documentation and example to show the agreed payload.
issue: no error listing related to study creation
issue: there are no request tests to cover the success and individual error cases
Yes, the payload is not decided yet. It will need to be updated later on when we know what attributes are passed in. |
Closes #
Changes proposed in this pull request
add create API endpoint
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version