Skip to content

Y25-485 - Remove API v1#5899

Open
StephenHulme wants to merge 5 commits into
Y25-485-remove-model-extensionsfrom
y24-485-remove-api-v1
Open

Y25-485 - Remove API v1#5899
StephenHulme wants to merge 5 commits into
Y25-485-remove-model-extensionsfrom
y24-485-remove-api-v1

Conversation

@StephenHulme

@StephenHulme StephenHulme commented Jul 3, 2026

Copy link
Copy Markdown
Member

Closes #5136

Built on #5309

Changes proposed in this pull request

  • Remove unused references to API v1
  • Remove API v1 dependencies

Line diff summary:

git diff-tree --stat=80 y25-485-remove-model-extensions HEAD | sed -e 's/+/❇️ /g' -e 's/-/⛔/g'
 Gemfile                                            |  10 ❇️ ⛔
 Gemfile.lock                                       |  13 ⛔⛔
 app/api/core/endpoint/basic_handler.rb             |  69 ⛔⛔⛔⛔⛔⛔⛔
 app/api/core/endpoint/basic_handler/actions.rb     | 134 ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
 .../core/endpoint/basic_handler/actions/bound.rb   |  21 ⛔⛔
 .../basic_handler/actions/bound/handler.rb         |  26 ⛔⛔⛔
 .../core/endpoint/basic_handler/actions/factory.rb |  28 ⛔⛔⛔
 .../core/endpoint/basic_handler/actions/guards.rb  |  73 ⛔⛔⛔⛔⛔⛔⛔
 .../endpoint/basic_handler/actions/inner_action.rb |  53 ⛔⛔⛔⛔⛔
 .../endpoint/basic_handler/actions/standard.rb     |  28 ⛔⛔⛔
 .../basic_handler/associations/belongs_to.rb       |  73 ⛔⛔⛔⛔⛔⛔⛔
 .../basic_handler/associations/has_file.rb         |  18 ⛔⛔
 .../basic_handler/associations/has_many.rb         |  19 ⛔⛔
 .../basic_handler/associations/has_many/handler.rb |  89 ⛔⛔⛔⛔⛔⛔⛔⛔
 .../core/endpoint/basic_handler/endpoint_lookup.rb |  47 ⛔⛔⛔⛔⛔
 app/api/core/endpoint/basic_handler/handlers.rb    |  43 ⛔⛔⛔⛔
 app/api/core/endpoint/basic_handler/paged.rb       |  95 ⛔⛔⛔⛔⛔⛔⛔⛔⛔
 app/api/core/io/base.rb                            |  29 ⛔⛔⛔
 app/api/core/io/base/eager_loading_behaviour.rb    |  11 ⛔
 app/api/core/io/base/json_formatting_behaviour.rb  |  81 ⛔⛔⛔⛔⛔⛔⛔⛔
 .../io/base/json_formatting_behaviour/input.rb     | 210 ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
 .../io/base/json_formatting_behaviour/output.rb    |  30 ⛔⛔⛔
 app/api/core/io/buffer.rb                          |  25 ⛔⛔⛔
 app/api/core/io/collection.rb                      |  16 ⛔⛔
 app/api/core/io/json/grammar.rb                    | 225 ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
 app/api/core/io/json/stream.rb                     | 146 ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
 app/api/core/io/list.rb                            |  22 ⛔⛔
 app/api/core/io/registry.rb                        |  14 ⛔⛔
 app/api/core/registry.rb                           |  69 ⛔⛔⛔⛔⛔⛔⛔
 docs/api_v1.md                                     |  46 ⛔⛔⛔⛔⛔
 test/unit/api/core/io/json/grammar_test.rb         |  82 ⛔⛔⛔⛔⛔⛔⛔⛔
 test/unit/api/core/io/json/stream_test.rb          | 120 ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
 test/unit/api/core/io/json_output_test.rb          | 199 ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
 33 files changed, 3 insertions(❇️ ), 2161 deletions(⛔)

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.10%. Comparing base (209ca8d) to head (1348974).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           Y25-485-remove-model-extensions    #5899      +/-   ##
===================================================================
+ Coverage                            84.96%   86.10%   +1.14%     
===================================================================
  Files                                 1298     1271      -27     
  Lines                                32073    31212     -861     
  Branches                              3547     3446     -101     
===================================================================
- Hits                                 27250    26875     -375     
+ Misses                                4799     4313     -486     
  Partials                                24       24              
Flag Coverage Δ
javascript 76.31% <ø> (ø)
ruby 86.11% <ø> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme marked this pull request as ready for review July 3, 2026 14:27
@StephenHulme StephenHulme self-assigned this Jul 3, 2026
@StephenHulme StephenHulme requested a review from sabrine33 July 3, 2026 14:27
@StephenHulme StephenHulme added SS API v1-->v2 Technical roadmap epic Tech roadmap 4 labels Jul 3, 2026
@StephenHulme StephenHulme requested a review from KatyTaylor July 3, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SS API v1-->v2 Technical roadmap epic Tech roadmap 4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants