Y26-209 - [PR] Disable MLWH Broadcasts for Sapio-managed Studies#5912
Open
yoldas wants to merge 6 commits into
Open
Y26-209 - [PR] Disable MLWH Broadcasts for Sapio-managed Studies#5912yoldas wants to merge 6 commits into
yoldas wants to merge 6 commits into
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5912 +/- ##
===========================================
- Coverage 84.86% 84.83% -0.04%
===========================================
Files 1492 1494 +2
Lines 33936 33954 +18
Branches 3613 3615 +2
===========================================
+ Hits 28799 28804 +5
- Misses 4286 4301 +15
+ Partials 851 849 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: #5903
Changes proposed in this pull request
Replace methods provided by Warren gem with alternatives to filter out Sapio Study records.
broadcast_with_warren_except_sapioclass method as an alternative tobroadcast_with_warren.broadcast_except_sapiomethod as an alternative tobroadcast.Studymodel to usebroadcast_with_warren_except_sapio, which automatically registers anafter_commitcallback.rebroadcastto usebroadcast_except_sapio; it is registered as anafter_touchcallback.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version