Repository navigation
release v1.41.2 DEV to main promotion - #2919
Merged
Merged
Conversation
The QA rebuild workflow builds Hugo directly via /tmp/hugo rather than `npm run build:all`, but was never given the build:icon-subset + build:css steps that commit ac6b7e3 (#2896 follow-up) added to the prod rebuild-content.yml when it .gitignored those generated CSS outputs. On a clean CI checkout fundamental-styles-icon.css is therefore absent, so head.html:27 (resources.Get "css/fundamental-styles-icon.css" | minify) fails with "wrong type for value; expected resources.ResourceTransformer; got resource.Resource" and every QA full rebuild dies at the Hugo step. Add a "Build fingerprinted CSS" step before the QA Hugo build, mirroring rebuild-content.yml, so QA and prod regenerate byte-identical CSS and agree on the fingerprint.
rebuild-content-qa.yml jumped from the island-manifest step straight to build:qa, with no step to generate the two gitignored CSS build outputs (fundamental-styles-icon.css via build:icon-subset, sap-fundamental.css via build:css). rebuild-content.yml (PROD) has had that step all along, so a clean QA checkout died at head.html:27 (resources.Get on the missing icon CSS) while PROD was unaffected. - Add the 'Build fingerprinted CSS (sap-fundamental + icon subset)' step to the QA workflow, in the same position PROD runs it (before the Hugo build). - Document the two-workflow parity rule + the list of gitignored Hugo build inputs in mta-deployment.md so the drift that caused this doesn't recur.
fix(ci): regenerate fingerprinted CSS before QA Hugo build (#2912)
# Conflicts: # .github/workflows/rebuild-content-qa.yml
docs: record QA/PROD rebuild-workflow parity rule (follow-up to #2917)
# Conflicts: # .deploy/mta.yaml # hugo/data/whats_new.json # mta-mcp.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.41.2 — DEV → main promotion
Patch release promoting the QA content-pipeline fix merged to
DEVsince 1.41.1 tomainfor a PROD deploy.Version bumps
tutorials-ims).deploy/mta.yamltutorials-mcp)mta-mcp.yamlPatch bump: CI/content-pipeline fix + doc only, no runtime/feature/schema change.
Changes in this window
Fixes
build:icon-subset+build:css) before the QA Hugo build, mirroring the PROD workflow. Fixes a clean QA checkout dying athead.html:27(missingfundamental-styles-icon.css) — i.e. content-qa rebuilds work after this deploy.Maintenance / Docs
mta-deployment.mdso the drift that caused fix(ci): regenerate fingerprinted CSS before QA Hugo build (#2912) #2917 doesn't recur (lists the gitignored Hugo build outputs + their generator scripts).What's New
hugo/data/whats_new.jsonregenerated via thewhats-newskill — #2917 added as a public Fix; #2918 and the release PRs carried as Maintenance.Deploy
Merging this PR does not redeploy — a separate blue-green MTA deploy is required (main MTA + the separate
tutorials-mcpMTA). This supersedes the v1.41.1 release (never deployed); 1.41.2 is the version going to PROD.🤖 Generated with Claude Code