Repository navigation
release v1.41.3 DEV to main promotion - #2925
Merged
Merged
Conversation
test/unit/hugo-homepage-partials.test.ts spawns a real Hugo build. head.html:27 does `resources.Get "css/fundamental-styles-icon.css" | minify | fingerprint`. Since ac6b7e3 stopped committing the generated CSS (sap-fundamental.css, fundamental-styles-icon.css are now gitignored build outputs), these assets are absent on a fresh checkout. unit-tests.yml never regenerated them, so resources.Get missed the asset, minify got a non-transformable resource.Resource, and the Hugo build exited 1 — failing 7 test files. rebuild-content.yml already regenerates these before its Hugo build; this mirrors that step (build:icon-subset + build:css) before npm test. Verified: without the assets Hugo exits 1 (4 minify errors); after the two gen steps Hugo exits 0 and hugo-homepage-partials.test.ts passes 4/4.
fix(ci): regenerate gitignored CSS before unit-test Hugo build
…PROUTER_URL_QA /tutorials-qa/* is served by the MAIN (prod) approuter (approuter/xs-app.json routes it to the srv-qa-api destination) — QA is a feature of production, not a separate environment. The asset guard referenced secrets.APPROUTER_URL_QA, which does not exist (repo has only APPROUTER_URL_DEV and APPROUTER_URL_PROD), so it resolved to an empty string and the guard die()d with 'missing --approuter-url' on every full QA rebuild. Point it at APPROUTER_URL_PROD.
fix(ci): QA asset guard probes PROD approuter (QA is a feature of prod)
# Conflicts: # .deploy/mta.yaml # hugo/data/whats_new.json # mta-mcp.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.41.3 — DEV → main promotion
Patch release promoting the CI fixes merged to
DEVsince 1.41.2 tomain. Primary driver: get the QA asset-guard fix (#2923) onto main so the QA content rebuild (which runs offmain) can be re-run and cleared.Version bumps
tutorials-ims).deploy/mta.yamltutorials-mcp)mta-mcp.yamlPatch: CI-only fixes, no runtime/feature/schema change.
Changes in this window
/tutorials-qa/*is routed by the main approuter tosrv-qa-api). It referenced a nonexistentAPPROUTER_URL_QAsecret → empty URL → guard died. This unblocks the QA content rebuild.Deploy / follow-up
Merging does not redeploy. These are CI-workflow fixes — no MTA redeploy required for #2922/#2923 to take effect; they run in GitHub Actions off
main. Once merged, re-run the full QA content rebuild to clear it. #2921 (glossary) will surface in content on the next content rebuild.🤖 Generated with Claude Code