Repository navigation
fix(tutorials): tag/level chips link to /tutorial-navigator/ not /tutorials/ - #2928
Merged
Merged
Conversation
release v1.41.1 DEV to main promotion
# Conflicts: # .deploy/mta.yaml # hugo/data/whats_new.json # mta-mcp.yaml
release v1.41.2 DEV to main promotion
I would not say that TypeScript is preferred for CAP. Also, "in this codebase" seems a bit disconnected generally, so I removed it.
fix: Modify glossary entry for TypeScript
# Conflicts: # .deploy/mta.yaml # hugo/data/whats_new.json # mta-mcp.yaml
release v1.41.3 DEV to main promotion
…orials/ The clickable tag and experience chips on the tutorial object page (and the Overview meta tags) deep-linked to /tutorials/?tag=<slug> and /tutorials/?level=, but there is no listing route at /tutorials/ — the AppRouter forwards /tutorials/* to CAP /content/tutorials/:slug, so an empty slug returned 'Cannot GET /content/tutorials/'. Point the chips at /tutorial-navigator/, which reads ?tag= and ?level= as issue #161 deep-link entry params (hugo-apps/src/navigator/ url-params.ts). Update the clickable-chips smoke test, which was asserting the broken /tutorials/ target. Verified with an isolated Hugo render of the chip blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking a tag or experience-level chip on a tutorial (both the object-page header chips and the Overview meta tags) produced
Cannot GET /content/tutorials/.The chips deep-linked to
/tutorials/?tag=<slug>and/tutorials/?level=<slug>, but there is no listing route at/tutorials/— the AppRouter forwards/tutorials/*to CAP/content/tutorials/:slug, so an empty slug 404s.Fix
Point all five chip anchors at
/tutorial-navigator/, which already reads?tag=and?level=as issue #161 deep-link entry params (hugo-apps/src/navigator/url-params.ts:20,30) and seeds its product/level filters from them.Files:
hugo/layouts/tutorials/u1-object-page.html— 2 level chips + 2 tag chips (displayTags + primaryTag)hugo/layouts/partials/tutorial-meta.html— Overview tag chipstest/smoke/clickable-chips.smoke.test.ts— was asserting the broken/tutorials/target; updated to/tutorial-navigator/Verification
Isolated Hugo render of the exact chip blocks confirms output:
/tutorial-navigator/?level=beginner/tutorial-navigator/?tag=software-product%3Ejoule-studio/tutorial-navigator/?tag=tutorial%3EbeginnerLicenselabel still suppressed;>still URL-encodes to%3E.