Skip to content

Fix the CURR-column download dump in ZCMRUPDATE_ADDON_TABLE #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KexiHe merged 1 commit into from
Aug 6, 2026
Merged

Fix the CURR-column download dump in ZCMRUPDATE_ADDON_TABLE #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,24 @@ All notable changes to this project will be documented in this file.

### Fixed

- **`ZCMRUPDATE_ADDON_TABLE` short-dumped on downloading any table with a CURR
column.** The `convert_to_external` CURR branch passed
`max_number_of_digits = 23` to `BAPI_CURRENCY_CONV_TO_EXTERNAL`, but that
parameter exists only on the `_TO_INTERNAL` twin (verified against the live
FM interface on S4D, 2026-08-07) — evidently copied from the upload branch,
where it is legitimate (mandatory, even). An unknown parameter raises
`CALL_FUNCTION_PARM_UNKNOWN`, a runtime error the surrounding
`CATCH cx_root` cannot intercept, so the first CURR field `do_download`
formatted dumped the run. The parameter is simply removed — the
`_TO_EXTERNAL` direction needs no digit cap; the upload path's
`_TO_INTERNAL` call is untouched, and no selection-screen field was renamed
(`sap_update_addon_prog.vbs` drives them by GUI field id). The compiler
syntax check does NOT catch this defect class (verified with a minimal
repro) — only an FM-signature check (`/sap-check-abap` `fm` dimension)
does. **Redeploy required**: the program `/sap-dev-init` deploys is
byte-identical to this reference copy, so every system carries the dump
until `ZCMRUPDATE_ADDON_TABLE` is redeployed via `/sap-dev-init` (or a
`/sap-se38` update).
- **Every safety-gate `assert` (and every other caller that omits the new
`ResolvedVia` out-parameter) refused with a false `no_profile` under Windows
PowerShell 5.1.** The RFC target-stamp work (PR #9) declared the parameter as
Expand Down
7 changes: 4 additions & 3 deletions plugins/sap-dev-core/skills/sap-update-addon/references/ZCMRUPDATE_ADDON_TABLE.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,11 +723,12 @@ CLASS lcl_table_util IMPLEMENTATION.
lv_curr_e = iv_currency.
TRY.
lv_amt_int = lv_val.
" No MAX_NUMBER_OF_DIGITS here: the parameter exists only on the
" _TO_INTERNAL twin; passing it dumps (CALL_FUNCTION_PARM_UNKNOWN).
CALL FUNCTION 'BAPI_CURRENCY_CONV_TO_EXTERNAL'
EXPORTING
amount_internal = lv_amt_int
currency = lv_curr_e
max_number_of_digits = 23
amount_internal = lv_amt_int
currency = lv_curr_e
IMPORTING
amount_external = lv_amt_ext
EXCEPTIONS
Expand Down