fix(harness): count the Agent Map generating state in the terminology allowlist - #849
Open
gwitwer wants to merge 1 commit into
Open
fix(harness): count the Agent Map generating state in the terminology allowlist#849gwitwer wants to merge 1 commit into
gwitwer wants to merge 1 commit into
Conversation
… allowlist `main` is red on `pnpm terminology:check`, and has been since #844: it added a third neutral Agent Map state to `AgentMapPane.tsx` carrying the same private `icon="Workflow"` design-system identifier, while the allowlist entry that covers that file still declares two. The guard treats an entry matching more than it declares as stale and fails, which is the guard working correctly. The third occurrence is the same private icon identifier as the other two, on `agent-map-generating`, a neutral state with no user-visible "workflow" anywhere. So the count is the thing that is wrong, not the code: bumped to three and the reason now names the generating state alongside loading and empty. Split out of #841 rather than fixed inside it. It is nobody's feature, it blocks every PR rebased past 8495be2, and it should be able to merge on its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019o9uM8fivJobCpT5zd4ChM
Contributor
Review — PR #849Verified independently:
Nits
Verdict: approve. One-line allowlist correction, factually accurate, unblocks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red onpnpm terminology:checkand has been since 8495be2 (the merge of #844). This is the one-line fix.What happened
#844 added a third neutral state to
AgentMapPane.tsx,agent-map-generating, carrying the same private design-systemicon="Workflow"identifier the loading and empty states already carry. The allowlist entry covering that file still declares"occurrences": 2. The guard fails an entry that matches more than it declares, which is the guard doing its job: an allowlist that silently absorbs new matches would stop being a record of what was reviewed.Why bumping the count is the right fix, not changing the code
All three matches are the
iconprop, a private design-system identifier, on neutral states:agent-map-loadingagent-map-generatingagent-map-emptyNo user-visible string says "workflow" in any of them, which is what the guard is actually protecting. The declared count is what is out of date, so it moves to three and the reason now names the generating state alongside the other two.
Verification
pnpm terminology:checkgoes from the failure above toAgent Studio terminology check passed (965 files, no stale allowlist entries).Why this is its own PR
It is nobody's feature, and it blocks every PR rebased past 8495be2, including #841. It should be able to merge on its own rather than ride in behind a feature review.
🤖 Generated with Claude Code
https://claude.ai/code/session_019o9uM8fivJobCpT5zd4ChM