refactor(harness): delete unused browser graph topology (SAP-3090) - #908
Open
ynadge wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (29)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ynadge
added this pull request to stack #894
September 9, 2026 23:15
ynadge
marked this pull request as ready for review
September 10, 2026 03:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
After shell entry points were removed, the old project renderer, loaders, topology and mock cache had no supported browser consumers. Keeping them made the retired protocol and ownership boundary ambiguous.
Summary and scope
Delete the unused graph components, parser/layout/navigation/grouping helpers, API methods, mock projection, announcements, graph-only fixtures and tests. Move retained viewport coverage to its neutral owner and give retained styles Agent Map names. Request counters observe actual legacy HTTP paths before boot. Most of this diff is deletion; per-agent Canvas and shared viewport math remain in use.
Related work
Related issue or discussion: SAP-3090. Part of the authorized cleanup stack above #892 and #893, targeting
main. Human review follows the complete stack. Implementation and PR creation do not authorize merging or releasing it.Validation
Verification on the cumulative implementation at
cab477b5(each earlier boundary also passed its affected build/typecheck and focused checks):The root test failure reproduces on unchanged prior code; it is not treated as a green root run. The final retirement record includes artifact hashes, request-observation scope and all local limitations.
Browser checks used installed Google Chrome, isolated TMPDIR and E2E_PORT=5497; the override changes only the executable, temporary output/report paths and Vite invocation. The package's 195 Harness runtime/assets match the clean build byte-for-byte. Its saved-map check records legacy read/refresh/navigation requests 0/0/0, direct removed routes 404/404/404, and unchanged map/history.
The first AppImage run failed session-create with a preexisting PROJECT_SESSION_SCOPE_UNAVAILABLE retention race; the identical artifact passed an isolated rerun. The initial failure and unchanged source ancestry are preserved in the record, with a separate follow-up test/fix outline. This cleanup does not fix that race. Signed macOS installer/upgrade evidence remains the SAP-3086 release gate.
Tests and documentation
All 1,124 browser unit cases passed at this boundary. All 48 focused browser cases covering authority, map layout/navigation/packing, project altitude and mobile passed. Retained viewport and analytics redaction tests passed. The retirement record documents the zero-request observation scope.
Compatibility and release impact
Security
AI assistance
Codex implemented the cleanup and test/doc migrations, traced retained callers, and checked the resulting diffs. Automated checks above and independent read-only review provide implementation evidence; maintainer review is still required.
Checklist
CONTRIBUTING.md, and this contribution follows the direct-PR or issue-first policy.