Skip to content

fix(nav): keep product topics reachable on narrow screens#787

Open
dhawani wants to merge 1 commit into
mainfrom
claude/slack-session-xqlopg
Open

fix(nav): keep product topics reachable on narrow screens#787
dhawani wants to merge 1 commit into
mainfrom
claude/slack-session-xqlopg

Conversation

@dhawani

@dhawani dhawani commented Jun 25, 2026

Copy link
Copy Markdown

The secondary nav bar is hidden at max-width 60rem, but the sidebar-topics fallback only reappeared at max-width 48rem, leaving a 48-60rem dead zone with no reachable top navigation. Align the fallback breakpoint to 60rem so topics show in the sidebar exactly when the bar is hidden.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the visibility behavior for the sidebar topics list so it appears on wider screens when the secondary navigation is hidden, improving navigation access on more layouts.

The secondary nav bar is hidden at max-width 60rem, but the
sidebar-topics fallback only reappeared at max-width 48rem, leaving a
48-60rem dead zone with no reachable top navigation. Align the
fallback breakpoint to 60rem so topics show in the sidebar exactly
when the bar is hidden.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0a2afbac-d5dc-48f9-bd83-37aef8b448a3

📥 Commits

Reviewing files that changed from the base of the PR and between b269a5e and 77d09b1.

📒 Files selected for processing (1)
  • src/components/SecondaryNav.astro
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: Redirect rules - scalekit-starlight
  • GitHub Check: Header rules - scalekit-starlight
  • GitHub Check: Pages changed - scalekit-starlight
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{md,mdx,astro,ts}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.{md,mdx,astro,ts}: Use pnpm pretty-quick --staged via pre-commit git hook to auto-format all staged .md, .mdx, .astro, .ts files with Prettier
Run pnpm format to auto-format all .md, .mdx, .astro, .ts files before pushing changes

Files:

  • src/components/SecondaryNav.astro
src/components/**/*.astro

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Reusable MDX components for documentation must be placed in src/components/ with subdirectories for auth, ui, examples, and templates

Files:

  • src/components/SecondaryNav.astro
src/components/SecondaryNav.astro

📄 CodeRabbit inference engine (CLAUDE.md)

Coordinate secondary navigation changes in src/components/SecondaryNav.astro with sidebar updates.

Coordinate navigation changes in src/components/SecondaryNav.astro when updating secondary navigation.

Files:

  • src/components/SecondaryNav.astro
**

⚙️ CodeRabbit configuration file

**: # CLAUDE.md - Scalekit Documentation Guide

Overview

This file is the single source of truth for all documentation standards and AI assistant guidelines in this repository. All documentation must adhere to the rules defined below.


Core Principles

Documentation-first development

Every feature must include comprehensive, user-focused documentation. Documentation is not an afterthought but a first-class deliverable that guides implementation. All code changes require corresponding documentation updates.

Git workflow

  • Do NOT include Co-Authored-By lines in commit messages
  • At the start of a fresh session, before making any changes, ask the user: "Do you want me to cut a new branch or work on the current branch?"
  • Never force push (git push --force or git push -f). If a push fails, stop and clearly explain the reason it failed — do not attempt workarounds without user confirmation.
  • For commit, push, and PR creation, spawn a subagent using the Haiku model to handle it. The pre-push hook generates large logs and PR creation output adds unnecessary noise to the main session context.
  • Once the user confirms local testing works, or explicitly asks to commit and push, commit all changes, push the branch, and open a PR against main. The PR must include:
    • A crisp description of the changes
    • A preview link in the format: https://deploy-preview-{PR_NUMBER}--scalekit-starlight.netlify.app/{path-to-changed-page}/

SDK variable names (critical)

CRITICAL: Use the exact variable names below in all documentation and code examples.

  • Node.js: scalekit
  • Python: scalekit_client
  • Go: scalekitClient
  • Java: scalekitClient

Multi-Language SDK Consistency

All code examples MUST include Node.js, Python, Go, and Java implementations with consistent variable naming conventions. Examples must show both success and error handling paths. Security implications must be explained for each implementation....

Files:

  • src/components/SecondaryNav.astro
🧠 Learnings (1)
📚 Learning: 2026-02-25T12:04:06.383Z
Learnt from: saif-at-scalekit
Repo: scalekit-inc/developer-docs PR: 445
File: src/pages/apis.astro:63-64
Timestamp: 2026-02-25T12:04:06.383Z
Learning: In the developer-docs repository, all Astro pages are intended to render in light mode. Enforce this by setting localStorage.colorMode = 'light' globally to ensure a consistent light theme across the site, including Scalar API reference pages. This should be treated as a deliberate, project-wide style decision rather than a per-page override; verify no page uses a conflicting color mode and document any exception in developer docs.

Applied to files:

  • src/components/SecondaryNav.astro
🔇 Additional comments (1)
src/components/SecondaryNav.astro (1)

255-257: LGTM!


Walkthrough

The secondary navigation stylesheet updates the breakpoint that reveals the global sidebar topics list, changing it from the mobile threshold to max-width: 60rem.

Changes

Sidebar topics visibility

Layer / File(s) Summary
Breakpoint update
src/components/SecondaryNav.astro
The inline comment and media-query threshold for :global(.starlight-sidebar-topics) now use max-width: 60rem.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the nav breakpoint fix that keeps product topics reachable on narrow screens.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/slack-session-xqlopg
  • 🛠️ fix frontmatter
  • 🛠️ fix internal links

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploy Preview for scalekit-starlight ready!

Name Link
🔨 Latest commit 77d09b1
🔍 Latest deploy log https://app.netlify.com/projects/scalekit-starlight/deploys/6a3d33afb0dfc50008e37c04
😎 Deploy Preview https://deploy-preview-787--scalekit-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 48 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants