Skip to content

Move Claude review workflows to scality/workflows@v2 - #74

Merged
g-carre merged 2 commits into
mainfrom
improvement/claude-review-v2
Oct 27, 2026
Merged

g-carre merged 2 commits into
mainfrom
improvement/claude-review-v2

Conversation

@matthiasL-scality

Copy link
Copy Markdown
Contributor

Follow-up to the Claude code review migration to Anthropic native authentication.

Changes

  • Move claude-code-dependency-review.yml from 284fcb6 (v2.12.0) to @v2, so the repository follows future v2 releases automatically.
  • Move claude-code-review.yml from 284fcb6 (v2.12.0) to @v2, so the repository follows future v2 releases automatically.
  • Remove GCP_WORKLOAD_IDENTITY_PROVIDER, GCP_SERVICE_ACCOUNT, ANTHROPIC_VERTEX_PROJECT_ID and CLOUD_ML_REGION. They are deprecated and unused since the migration.

No permission change is needed: v2 requires the same job permissions as before (id-token: write included).

@ezekiel-alexrod

Copy link
Copy Markdown
Contributor

Hello @matthiasL-scality, fine for me to drop the GCP secrets.

One question: on the platform repos we pin scality/workflows by SHA with a # vX.Y.Z comment, so Renovate tracks the bumps (target state of MK8S-452). Could we keep @284fcb6c972f27f628e342199064ba8ccd5df8c2 # v2.12.0 instead of @v2?

Unless @v2 is now the recommended way, in which case I'll update our target state.

@matthiasL-scality

Copy link
Copy Markdown
Contributor Author

Hello @matthiasL-scality, fine for me to drop the GCP secrets.

One question: on the platform repos we pin scality/workflows by SHA with a # vX.Y.Z comment, so Renovate tracks the bumps (target state of MK8S-452). Could we keep @284fcb6c972f27f628e342199064ba8ccd5df8c2 # v2.12.0 instead of @v2?

Unless @v2 is now the recommended way, in which case I'll update our target state.

no pb for me, i can update with the sha instead

@g-carre
g-carre merged commit ae26f9b into main Oct 27, 2026
8 checks passed
@g-carre
g-carre deleted the improvement/claude-review-v2 branch October 27, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants