Skip to content

5.4.26#113

Open
mscasso-scanoss wants to merge 2 commits into
mainfrom
5.4.26
Open

5.4.26#113
mscasso-scanoss wants to merge 2 commits into
mainfrom
5.4.26

Conversation

@mscasso-scanoss
Copy link
Copy Markdown
Contributor

@mscasso-scanoss mscasso-scanoss commented May 27, 2026

Summary by CodeRabbit

  • Chores

    • Version bumped to 5.4.26
  • Bug Fixes

    • Fixed file extension extraction to correctly identify extensions only in file basenames
    • Improved component matching logic to more accurately rank candidates based on extension matching during scanning operations

Review Change Stack

@mscasso-scanoss mscasso-scanoss self-assigned this May 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 90c5e1c1-616a-4283-8686-1bc20b1ccbb0

📥 Commits

Reviewing files that changed from the base of the PR and between e165249 and d6cbf0a.

📒 Files selected for processing (3)
  • inc/scanoss.h
  • src/ignorelist.c
  • src/match.c

📝 Walkthrough

Walkthrough

This PR releases version 5.4.26 with two extension handling fixes: extension() now correctly extracts extensions only from filenames (not parent directories), and compare_file_extension() now only prefers candidates when their extracted extensions exactly match the scanned file.

Changes

Extension Handling Fix and Release

Layer / File(s) Summary
Version bump to 5.4.26
inc/scanoss.h
Release version constant updated from 5.4.25 to 5.4.26.
Extension extraction and comparison fix
src/ignorelist.c, src/match.c
extension() now returns only the substring after the final dot when that dot appears after the last slash (baseline extension), returning NULL otherwise, eliminating fallback behavior for slash/dot edge cases. compare_file_extension() now returns non-zero only when exactly one candidate's extension matches the scanned file's extension, removing preference based solely on extension presence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • scanoss-qg

Poem

A rabbit hops through paths so deep,
Finding dots where basenames sleep,
Extensions true, no parent's disguise,
Matching files with sharper eyes,
Version bumped, the fix complete! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title '5.4.26' is vague and fails to describe the actual changes made in the pull request, which include version updates, extension parsing logic fixes, and component ordering improvements. Revise the title to clearly summarize the main changes, such as 'Fix extension matching logic and bump version to 5.4.26' or 'Update version and refine component ordering based on extension matching'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 5.4.26

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant