Skip to content

docs: add asd-ste100 and deliver-package skills - #279

Merged
cofade merged 2 commits into
mainfrom
docs/skill-library-port
Aug 31, 2026
Merged

docs: add asd-ste100 and deliver-package skills#279
cofade merged 2 commits into
mainfrom
docs/skill-library-port

Conversation

@cofade

@cofade cofade commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Ports the asd-ste100 and deliver-package skills from the open-garden-planner repo and adapts them to HiveHive conventions.

What ships

asd-ste100 — Simplified Technical English for agent-consumed text, ported nearly verbatim (repo-agnostic by design) with a fresh references/writing-rules.md and examples/before-after.md (the source repo's links were dead). Use it for error strings another agent or system will parse, tool descriptions, status reports, and inter-agent instructions.

deliver-package — the "take the next cluster of issues end to end" workflow, rewritten against HiveHive reality:

  • ground truth from the AGENTS.md self-removing priority queue (tracking epic 262) + gh issue list + the roadmap snapshot, with a note that clearing a queue entry is part of the package's commit
  • the actual gate battery (npm run typecheck/lint, bash scripts/ruff.sh check/format --check, make test-esp-native/test-e2e/test-ui, per-service suites, pio run -e esp32cam)
  • dev-stack verification rules (prove UI claims against docker compose up, Playwright specs, the three-failure-modes table)
  • main + gated production branch model: a draft PR to main never ships firmware (SEQUENCE bump + prod-<codename> tag are a separate release)
  • decision-carrying issues: decision + fix: titles with a Recommendation: are implementable up to the point the issue reserves a "Maintainer decision" box (issue 234 is the exemplar)
  • close-keyword hygiene: Closes #N in PR titles/commit subjects only, never bodies

Wiring — wherever the skills are mentioned or required:

  • .gitignore allow-list entries for both skill trees (both sides of the mirror)
  • AGENTS.md/CLAUDE.md (kept byte-identical, 35 230 / 36 864 Codex budget): new "Skill library" routing table, deliver-package sentence in the priority-queue section, asd-ste100 sentence in the documentation-duty section

Verification

  • bash scripts/check-agent-context.sh — OK (root docs pair + all four skill mirrors byte-identical; also re-run by the pre-push hook)
  • bash scripts/check-doc-citations.sh — 7 OK, 0 problems
  • Pre-push repo-guard battery — all green (stale-prose, display-name, hardcoded-keys, duckdb-bind-claims, python-version, python-twins 5/5)
  • Three senior-reviewer rounds (emulated via a general agent since opencode lacks the senior-reviewer subagent type; that gotcha is now documented in AGENTS.md) — ended clean; the P1s found (an invented issue-body quote, a misnamed i18n drift) were fixed and re-verified against gh issue view 234 and chapter 11

Notes for manual review

  • Reading the two SKILL.md files entirely (~140 + ~285 lines) is the main review; both have byte-identical .agents mirrors that must never diverge (ADR-033).
  • The Closes #N-in-titles rule and the firmware-release boundary are the two places where the skill asserts repo policy — check the wording against AGENTS.md.

review added 2 commits September 1, 2026 01:23
Port the two skills from the open-garden-planner repo and adapt them to
HiveHive conventions: priority-queue sourcing, main + production branch
model, the full gate battery, dev-stack verification, and the draft-PR
landing rule. Mirrored byte-identically into .claude/skills/ and
.agents/skills/ per the check-agent-context allow-list. AGENTS.md and
CLAUDE.md gain a skill-library routing table; the priority-queue and
documentation-duty sections wire the new skills in.
lint-staged formats .claude/skills/** but .prettierignore excludes
.agents/skills/**, so the committed .claude copies had been reformatted
while their .agents mirrors had not, breaking the ADR-033 byte parity.
Reconcile by copying the formatted .claude trees over the mirrors.
@cofade
cofade merged commit 18312f0 into main Aug 31, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant