Optimize __or__ operator performance - #185
Conversation
Avoids calling `__init__` when generating the result `BitVector`, which previously initialized a zeroed array that was immediately overwritten, by instead instantiating with `__new__` and directly assigning the `_size` and `vector` attributes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit refactors the
__or__method inBitVectorto skip__init__instantiation overhead.When a new result is created, we use
__new__and manually populate_sizeandvector.This gives a noticeable performance improvement for bitwise operations.
PR created automatically by Jules for task 4563464660271752357 started by @schwehr