feat: Add MmapBitVector implementation leveraging memory mapped arrays - #76
feat: Add MmapBitVector implementation leveraging memory mapped arrays#76google-labs-jules[bot] wants to merge 2 commits into
Conversation
- Refactored `BitVector.py` into a robust abstract class by formalizing `_allocate_vector`, `_set_vector`, `_extend_vector`, and `_copy_vector` hooks. - Implemented `MmapBitVector` in `BitVector/mmap_bitvector.py` leveraging Python's `mmap` module combined with `memoryview` objects for ultra-fast allocations and operations over shared OS memory blocks. - Added comprehensive pytest-benchmark integration tracking `MmapBitVector` initialization, `AND`, and `INVERT` operations spanning large memory spaces (2**15 to 2**22). All benchmarks complete successfully while respecting OS limitations around `memoryview` reallocation logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Refactored `BitVector.py` into an extensible abstract class by formalizing `_allocate_vector`, `_set_vector`, `_extend_vector`, and `_copy_vector` hooks. - Implemented `MmapBitVector` in `BitVector/mmap_bitvector.py` leveraging Python's `mmap` module combined with `memoryview` objects for ultra-fast allocations and operations over OS memory pages. - Handled edge cases correctly with `array.array` and `list` internal mechanisms safely without breaking the `BitVector` baseline. - Fixed strict type hinting failures generated by `mypy`, `ty check`, `pyright`, and `pyrefly` to reflect the multi-type vector approach (`array.array | list | memoryview | Any`). - Validated performance against benchmark sizes 2**15 to 2**22 safely. All 439 tests complete successfully.
Implement MmapBitVector by refactoring
BitVectorto be more dynamically typed and subclass-friendly with explicit generic abstract methods.MmapBitVectorinherits from this functionality to inject OS memory-mapped allocations via the built-inmmapcapability without mutating base functionality. The solution maintains full typing checks while offering comprehensive runtime benchmarking support for high performance vector handling.PR created automatically by Jules for task 8669761054652236053 started by @schwehr