Write meshtags on input mesh#50
Conversation
…can now write meshtags on input mesh.
finsberg
left a comment
There was a problem hiding this comment.
This is great @jorgensd! This is definitely the source of many bugs that I have encountered, and I am wonder whether it would make sense to make the default behaviour to use the input mesh (also for function)? I know that it will not be as performant, but IMO it is better to avoid bugs, than being a bit more performant 🙃
I refuse to change the default behaviour of the functions;
|
| if is_complex: | ||
| values[0] -= 3j * x[1] | ||
| values[1] += 2j * x[0] |
There was a problem hiding this comment.
Perhaps we can just remove this, it is_complex always is False?
There was a problem hiding this comment.
Sure, remainder from copying old test
(Looking at you @finsberg and @MariusCausemann) we can now write meshtags on input mesh.