Repository navigation
MNT Disable pytest capture warnings by using pyproject.toml - #22
Merged
Merged
Conversation
jeremiedbb
reviewed
Oct 2, 2026
Comment on lines
+28
to
+30
| pytest -c $SCIKIT_LEARN_DIR --pyargs sklearn -n $XDIST_WORKERS | ||
| else | ||
| pytest --pyargs sklearn | ||
| pytest -c $SCIKIT_LEARN_DIR --pyargs sklearn |
Member
There was a problem hiding this comment.
didn't you forget to add back "/pyproject.toml" ?
or maybe even define SCIKIT_LEARN_CONFIG_FILE from start.
Member
Author
|
This seems to work fine (finally 😝) see build log. You need to click a few times to eventually get to the "test wheels" part of the log. |
lesteve
commented
Oct 5, 2026
|
|
||
| PROJECT_DIR="$1" | ||
| SCIKIT_LEARN_CONFIG=$( | ||
| python -c 'import os, sys; print(os.path.realpath(sys.argv[1]))' \ |
Member
Author
There was a problem hiding this comment.
I started with using realpath but apparently it doesn't exist on macOS and the simplest alternative was to use a python one-liner ...
Member
Author
|
Merging this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #21