DO NOT MERGE - #1
Open
arnaudbore wants to merge 3 commits into
Open
arnaudbore wants to merge 3 commits into
arnaudbore wants to merge 3 commits into
Conversation
Root causes addressed: 1. Geometry overwrite - TRK vox_to_ras transform restored after loading 2. Visibility callbacks - Forced visibility at multiple pipeline stages 3. 2D slicing - Implemented vtkCutter geometric slicing (VTK 9 shader API removed) Modified files: - Modules/DiffusionIO/mitkFiberBundleTrackVisReader.cpp (geometry restoration) - Modules/ImekaFiber/ImekaFiber/FibersManager.cpp (visibility forcing) - Modules/ImekaFiber/ImekaFiber/Mapper/MitkFiberMapper2D.cpp (vtkCutter slicing) - Modules/ImekaFiber/ImekaFiber/Mapper/MitkFiberMapper3D.cpp (visibility forcing) - Plugins/org.imeka.mibrain.view/src/internal/BrainAnalysisView.cpp (removed auto-reinit) - README.rst (updated for MITK 2025 with known issues) - MITK_2025_FIBER_VISIBILITY_FIXES.md (comprehensive documentation) Status: Rendering pipeline confirmed working, but fibers still invisible. See MITK_2025_FIBER_VISIBILITY_FIXES.md for complete details.
- Remove unused variable 'pts' in FilteredFiberBundle.cpp - Add (void) casts for unused parameters in InteractorEmitter.cpp - Remove unused parameter names in ShuffleTractsAction and Toggle2DAction - Change loop variable to reference in ColorUniformAction to avoid unnecessary copy Build now completes with zero warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.