Fix Cython 3.3 compatibility - #1248
Merged
Merged
Conversation
Do not redeclare variables with different types. Use new names rather than redeclaring/shadowing the old ones. Fixes scipopt#1247.
Labeeb2339
reviewed
Aug 27, 2026
Labeeb2339
left a comment
Labeeb2339
left a comment
There was a problem hiding this comment.
I reviewed the Cython compatibility change. Normalizing the public axis argument into axis_tuple keeps the original axis parameter available while updating every downstream membership, shape, and transpose use consistently. The change is minimal and directly addresses the typed redeclaration, and I found no additional issue in the diff.
Member
|
Thank you for the fix @musicinmybrain ! Can you please add a CHANELOG entry? And thank you @Labeeb2339 for the review!! |
Contributor
Author
You’re welcome!
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not redeclare variables with different types. Use new names rather than redeclaring/shadowing the old ones.
Fixes #1247. See also cython/cython#7246.