Skip to content

[CI] Remove draft release CI step#666

Merged
nvaytet merged 1 commit into
mainfrom
remove-draft-release-ci-step
Jul 7, 2026
Merged

[CI] Remove draft release CI step#666
nvaytet merged 1 commit into
mainfrom
remove-draft-release-ci-step

Conversation

@nvaytet

@nvaytet nvaytet commented Jul 3, 2026

Copy link
Copy Markdown
Member

The draft release step when making a release goes wrong when we make a release via the web UI.

A draft release with the same name using the same tag is created alongside the release already created by the web UI.
Screenshot_20260703_132021

Then, the release notes of the non-draft release get updated.
The uploading of the docs as assets fails.
The draft release never gets promoted to non-draft, because the original release gets picked up by the gh command.

For now, we remove this step, meaning that releases should only be created via the web interface (simply pushing a tag from the CLI will no longer work).
We should revisit once everyone is back from vacation.

@nvaytet nvaytet requested a review from jl-wynen July 3, 2026 11:23
@nvaytet nvaytet added the CI label Jul 3, 2026
@nvaytet nvaytet added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit 4850c7a Jul 7, 2026
7 checks passed
@nvaytet nvaytet deleted the remove-draft-release-ci-step branch July 7, 2026 07:31
@YooSunYoung

Copy link
Copy Markdown
Member

The gh release create changed its behaviour ... it used to fail when there is a release with the same tag already but now it goes through. We could probably fix it by adding an if condition in the draft release creating step but it's also fine we just stick to the gh client and web UI...??

One downside is just we'll have to type more things when we want to run batch releases.
With the tag way, we just need to push multiple tags but with this change we'll have to use gh release... which is not too bad....??

But I think the docs build assets upload failed for different reason. I'll try fixing it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants