fix(audit): audit-all partial-green (cli 22E→14E, project/apis/skills clean) - #377
Open
ywatanabe1989 wants to merge 1 commit into
Open
ywatanabe1989 wants to merge 1 commit into
ywatanabe1989 wants to merge 1 commit into
Conversation
…22E→14E (peer-owned skips documented) - audit-project: 0 errors; audit-python-apis + audit-skills SUCC - audit-cli owned fixes: mcp examples/--dry-run/--yes, installation→show-installation (+hidden compat alias), --json on show-installation; new 'skills install' (symlink bundles to SKILLS_DIR, --dry-run/--yes/--claude-symlink), --json on 'skills get', flags on 'skills export'; eager-load skills group for static audit - Remaining 14 cli errors are peer-owned or rule-vs-doctrine conflicts (see PR body)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verdicts (auditor: scitex-dev,
ecosystem audit-all scitex, exit 1 — partial green, expected)[defer]PS-103 root-whitelist note — auditor classifier can't classify its own defer line; scitex-dev bug, not a finding)Fixed in this PR (cli 22→14)
mcp list-tools/doctor/start/installation: §4 concrete examples in docstringsmcp start: genuine--dry-run(prints plan, binds nothing) +-y/--yesmcp installation→show-installation(§1 compound-leaf); old name kept as hidden compat alias (walker skips hidden); docs updatedmcp show-installation:--jsonemits the raw Claude Desktop configskills install(doctrine 03 §1e: symlink_skills/<pkg>/→$SCITEX_DIR/dev/skills/<pkg>/,--claude-symlink,--dry-run,-y/--yeswith real replace-gate semantics);--jsononskills get;--dry-run/--yesonskills export;skillseager-loaded inmain.pyso the static walk sees it (was falsely reported missing)Remaining 14 errors — skips with reasons (DO NOT fix per-repo)
main unregister-source/keygen§1d dictmaingroup (dag/chain/list-runs peer CLI)event latest/history/types§1 noun-leafshow-latestetc. is breaking; needs doctrine decision, not a drive-bysocial delete/me/analytics,social mcp start/list-tools/installation§1/§2social.pyheader: thin wrapper around socialia CLI)social mcp installation§1install-shell-completion/print-shell-completion§1aattach_shell_completion; package doctrine §1b (CLI-standardization slice 5) deliberately retired that shape for thecompletionnoun group.attach_would also register a collidingcompletionalias + duplicate the owned group. Needs scitex-dev rule review (cf. playbook §8)Warnings (rule-review, not per-repo fixes)
main+ 1 peersocial), 3× §13. NOTE: new §13 warns top-levelskillsshould nest underdev, while §1a errors if top-levelskills {list,get,install}is absent — auditor self-contradiction, kept the §1a-mandated shape.skills installtargets the doctrine-mandated~/.scitex/dev/skills/path (2 pre-existing PS-145 siblings); dest honors $SCITEX_DIR.Tests
pytest tests -q: 577 passed, 91 skipped, 44 xfailed, 17 xpassed, 0 failed (full suite, worktree venv).origin/develop(temp worktree, read-only): 576 passed, 0 failed → no pre-existing failures; branch introduces none.test_every_standalone_writer_tool_is_reachable_via_umbrellafailing (writer peer-mount timing); passes in isolation, on pristine, and on all subsequent full runs — ordering/load flake, not a regression.Files (19, +974/−647)
Prior partial-run work + this session:
cli/mcp.py,cli/skills.py,cli/main.py(eager skills),docs/sphinx/source/mcp.rst, plus carried-over audit fixes (logging migration, pyproject, lazy wiring, mcp registry, usage/helpers, tests). No scitex-dev or other packages touched.DO NOT MERGE yet — partial-green PR for review; remaining 14 errors need peer-side or auditor-rule resolution.