fix(ci): require new changeset per PR, emit one from schema regen#157
Merged
fix(ci): require new changeset per PR, emit one from schema regen#157
Conversation
benminer
force-pushed
the
feature/schema-changeset
branch
from
15f1d74 to
636e0ed
Compare
nastassiafulconis
approved these changes
Apr 24, 2026
The changeset-check only verified that *some* changeset existed in .changeset/. Any pending unreleased changeset let every subsequent PR pass, so schema-regen PRs like #153 and #155 merged without adding a changeset — leaving the release PR out of sync with the code. Compare the PR diff against its base and fail unless a new .md file is added. Also make the regenerate-schemas workflow emit a .changeset entry alongside src/schemas/ so auto-generated schema PRs bump the version.
benminer
force-pushed
the
feature/schema-changeset
branch
from
636e0ed to
68e2389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.changeset/was empty, so any pending unreleased changeset let every PR pass. That's how PRs chore: regenerate schemas from OpenAPI spec #153 and fix(schemas): pre-process spec to patch broken Error $refs #155 merged schema updates without adding changesets — and why the "Version Packages" PR (chore: version packages #152) doesn't reflect any of the schema work..changeset/*.mdfile is added. Escape hatch for opt-outs isnpx changeset --empty.minorbump) alongsidesrc/schemas/so future auto-regen PRs bump the version.Test plan
yaml.safe_loadgit diff --diff-filter=A BASE...HEAD -- '.changeset/*.md'correctly lists the new file on this branchnpm run type-checkpasses