Run Tests on PRs regardless of base branch#46
Merged
Conversation
`branches: ['*']` looks like "all branches" but the `*` glob does not match `/`, so the Tests workflow silently skipped any PR whose base branch contains a slash (e.g. a stacked PR based on another PR's claude/... branch). Drop the filter; a bare pull_request trigger covers every base branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JHvKryT4QUpHYdNq9YEQxX
Phlogistique
force-pushed
the
claude/tests-all-base-branches-3njvdx
branch
from
0eae486 to
e7e0f55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branches: ['*']looks like "all branches", but in GitHub's filter pattern syntax the*glob does not match/— andpull_request.branchesfilters on the base branch. So the Tests workflow silently skipped any PR whose base branch contains a slash. Concretely: #45 is stacked on #42'sclaude/...branch and got no Tests run at all.Drop the filter — a bare
pull_request:trigger covers every base branch. ('**'would too, but no filter says what it means.) The README's example workflows never had a filter, so no doc change is needed beyond the inline comment.🤖 Generated with Claude Code
https://claude.ai/code/session_01JHvKryT4QUpHYdNq9YEQxX
Generated by Claude Code