basic support for AnnData accessors#147
Open
ilia-kats wants to merge 1 commit intoscverse:mainfrom
Open
Conversation
this should keep scanpy plotting working with MuData objects
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 91.54% 90.86% -0.69%
==========================================
Files 10 10
Lines 1585 1598 +13
==========================================
+ Hits 1451 1452 +1
- Misses 134 146 +12
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point of this is to still be able to pass MuData objects to scanpy's plotting functions. This is currently possible due to MuData's implementation of
obs_vectorandvar_vector, but if I understand the scanpy changes correctly (e.g. here) this will stop working as soon as anndata 0.13 is released.The logic is based on the current
_attr_vectorimplementation, which will go away at some point whenobs_vectorandvar_vectorare removed.I'd appreciate some feedback on where else scanpy has switched to accessors. For example, it is currently possible to run
sc.pp.neighborsandsc.tl.umapon a MuData object. Have these also switched to using accessors to access.obsm/obsp?